Fix syncUIAndState bug. Show tooltips on disabled sliders

ndshv · ndshv · commit 0d878b0815fe · 2020-11-14T11:47:17.000+02:00
diff --git a/packages/main/src/SliderBase.js b/packages/main/src/SliderBase.js
@@ -249,7 +249,7 @@ class SliderBase extends UI5Element {
 	 * @private
 	 */
 	_onmouseover(event) {
-		if (!this.disabled || this.showTooltip) {
+		if (this.showTooltip) {
 			this._tooltipVisibility = "visible";
 		}
 	}
@@ -450,7 +450,7 @@ class SliderBase extends UI5Element {
 		}
 
 		// Recalculate the tickmarks and labels and update the stored state.
-		if (this.isPropertyUpdated("min", "max", values)) {
+		if (this.isPropertyUpdated("min", "max", ...values)) {
 			this._normalizeMinMaxValues(this.min, this.max);
 			this._drawDefaultTickmarks(this.step, this.max, this.min);
 			this.storePropertyState("min", "max");

Original file line number	Diff line number	Diff line change
`@@ -249,7 +249,7 @@ class SliderBase extends UI5Element {`
`249`	`249`	`* @private`
`250`	`250`	`*/`
`251`	`251`	`_onmouseover(event) {`
`252`		`- if (!this.disabled \|\| this.showTooltip) {`
	`252`	`+ if (this.showTooltip) {`
`253`	`253`	`this._tooltipVisibility = "visible";`
`254`	`254`	`}`
`255`	`255`	`}`
`@@ -450,7 +450,7 @@ class SliderBase extends UI5Element {`
`450`	`450`	`}`
`451`	`451`
`452`	`452`	`// Recalculate the tickmarks and labels and update the stored state.`
`453`		`- if (this.isPropertyUpdated("min", "max", values)) {`
	`453`	`+ if (this.isPropertyUpdated("min", "max", ...values)) {`
`454`	`454`	`this._normalizeMinMaxValues(this.min, this.max);`
`455`	`455`	`this._drawDefaultTickmarks(this.step, this.max, this.min);`
`456`	`456`	`this.storePropertyState("min", "max");`