Skip to content

Commit 174f4b4

Browse files
authored
fix(framework): fix OpenUI5Support usage in applyTheme (#7485)
OpenUI5Support should have been imported as a type, not importing the feature itself. Importing the feature is done by the consumers, when they need better OpenUI5 integration.
1 parent 7a6039b commit 174f4b4

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

packages/base/src/theming/applyTheme.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import getThemeDesignerTheme from "./getThemeDesignerTheme.js";
44
import { fireThemeLoaded } from "./ThemeLoaded.js";
55
import { getFeature } from "../FeaturesRegistry.js";
66
import { attachCustomThemeStylesToHead, getThemeRoot } from "../config/ThemeRoot.js";
7-
import OpenUI5Support from "../features/OpenUI5Support.js";
7+
import type OpenUI5Support from "../features/OpenUI5Support.js";
88
import { DEFAULT_THEME } from "../generated/AssetParameters.js";
99
import { getCurrentRuntimeIndex } from "../Runtimes.js";
1010

@@ -56,7 +56,7 @@ const detectExternalTheme = async (theme: string) => {
5656

5757
// If OpenUI5Support is enabled, try to find out if it loaded variables
5858
const openUI5Support = getFeature<typeof OpenUI5Support>("OpenUI5Support");
59-
if (openUI5Support && OpenUI5Support.isOpenUI5Detected()) {
59+
if (openUI5Support && openUI5Support.isOpenUI5Detected()) {
6060
const varsLoaded = openUI5Support.cssVariablesLoaded();
6161
if (varsLoaded) {
6262
return {

0 commit comments

Comments
 (0)