Skip to content

Commit 2314fc3

Browse files
fifoosidfifoosid
authored
refactor(ui5-messagestrip): rename hideIcon property to noIcon (#507)
BREAKING CHANGE: hideIcon property is renamed to noIcon
1 parent f949455 commit 2314fc3

File tree

4 files changed

+18
-18
lines changed

4 files changed

+18
-18
lines changed

‎packages/main/src/MessageStrip.hbs

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
aria-live="assertive"
44
aria-labelledby="{{_id}}">
55

6-
{{#unless hideIcon}}
6+
{{#unless noIcon}}
77
<ui5-icon class="ui5-messagestrip-icon" src="{{messageStripIcon}}"></ui5-icon>
88
{{/unless}}
99

‎packages/main/src/MessageStrip.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ const metadata = {
6363
* @defaultvalue false
6464
* @public
6565
*/
66-
hideIcon: {
66+
noIcon: {
6767
type: Boolean,
6868
},
6969

@@ -197,7 +197,7 @@ class MessageStrip extends UI5Element {
197197
}
198198

199199
get hiddenText() {
200-
return `Message Strip ${this.type} ${this.hideCloseButton ? "" : "closable"}.`;
200+
return `Message Strip ${this.type} ${this.noCloseButton ? "" : "closable"}.`;
201201
}
202202

203203
get _closeButtonText() {
@@ -215,7 +215,7 @@ class MessageStrip extends UI5Element {
215215
},
216216
main: {
217217
"ui5-messagestrip-root": true,
218-
"ui5-messagestrip-icon--hidden": this.hideIcon,
218+
"ui5-messagestrip-icon--hidden": this.noIcon,
219219
"ui5-messagestrip-close-icon--hidden": this.noCloseButton,
220220
[this.typeClasses]: true,
221221
},

‎packages/main/test/sap/ui/webcomponents/main/pages/MessageStrip.html

+2-2
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,8 @@
4141
<ui5-messagestrip class="top" type="Information">Information with default icon.</ui5-messagestrip>
4242
<ui5-messagestrip class="top" type="Information">Ea mollit nulla laborum et fugiat nulla excepteur ea. Duis et dolor enim Lorem laboris adipisicing cillum quis proident dolor veniam voluptate. Nostrud dolore ipsum anim voluptate enim dolore eiusmod aliqua et. Est eu ex dolor ea ipsum. Adipisicing duis aliquip ullamco culpa dolore exercitation ullamco cillum irure.</ui5-messagestrip>
4343

44-
<ui5-messagestrip hide-icon class="top" type="Information">Ea mollit nulla laborum et fugiat nulla excepteur ea. Duis et dolor enim Lorem laboris adipisicing cillum quis proident dolor veniam voluptate. Nostrud dolore ipsum anim voluptate enim dolore eiusmod aliqua et. Est eu ex dolor ea ipsum. Adipisicing duis aliquip ullamco culpa dolore exercitation ullamco cillum irure.</ui5-messagestrip>
45-
<ui5-messagestrip hide-icon no-close-button class="top" type="Information">Ea mollit nulla laborum et fugiat nulla excepteur ea. Duis et dolor enim Lorem laboris adipisicing cillum quis proident dolor veniam voluptate. Nostrud dolore ipsum anim voluptate enim dolore eiusmod aliqua et. Est eu ex dolor ea ipsum. Adipisicing duis aliquip ullamco culpa dolore exercitation ullamco cillum irure.</ui5-messagestrip>
44+
<ui5-messagestrip no-icon class="top" type="Information">Ea mollit nulla laborum et fugiat nulla excepteur ea. Duis et dolor enim Lorem laboris adipisicing cillum quis proident dolor veniam voluptate. Nostrud dolore ipsum anim voluptate enim dolore eiusmod aliqua et. Est eu ex dolor ea ipsum. Adipisicing duis aliquip ullamco culpa dolore exercitation ullamco cillum irure.</ui5-messagestrip>
45+
<ui5-messagestrip no-icon no-close-button class="top" type="Information">Ea mollit nulla laborum et fugiat nulla excepteur ea. Duis et dolor enim Lorem laboris adipisicing cillum quis proident dolor veniam voluptate. Nostrud dolore ipsum anim voluptate enim dolore eiusmod aliqua et. Est eu ex dolor ea ipsum. Adipisicing duis aliquip ullamco culpa dolore exercitation ullamco cillum irure.</ui5-messagestrip>
4646
<ui5-messagestrip no-close-button class="top" type="Information">Ea mollit nulla laborum et fugiat nulla excepteur ea. Duis et dolor enim Lorem laboris adipisicing cillum quis proident dolor veniam voluptate. Nostrud dolore ipsum anim voluptate enim dolore eiusmod aliqua et. Est eu ex dolor ea ipsum. Adipisicing duis aliquip ullamco culpa dolore exercitation ullamco cillum irure.</ui5-messagestrip>
4747

4848

‎packages/main/test/sap/ui/webcomponents/main/samples/MessageStrip.sample.html

+12-12
Original file line numberDiff line numberDiff line change
@@ -84,16 +84,16 @@ <h3>MessageStrip With No Close Button</h3>
8484
<section>
8585
<h3>MessageStrip With No Icon</h3>
8686
<div class="snippet">
87-
<ui5-messagestrip class="samples-margin-bottom" type="Information" hide-icon>Information MessageStrip With No Icon</ui5-messagestrip>
88-
<ui5-messagestrip class="samples-margin-bottom" type="Positive" hide-icon>Positive MessageStrip With No Icon</ui5-messagestrip>
89-
<ui5-messagestrip class="samples-margin-bottom" type="Negative" hide-icon>Negative MessageStrip With No Icon</ui5-messagestrip>
90-
<ui5-messagestrip class="samples-margin-bottom" type="Warning" hide-icon>Warning MessageStrip With No Icon</ui5-messagestrip>
87+
<ui5-messagestrip class="samples-margin-bottom" type="Information" no-icon>Information MessageStrip With No Icon</ui5-messagestrip>
88+
<ui5-messagestrip class="samples-margin-bottom" type="Positive" no-icon>Positive MessageStrip With No Icon</ui5-messagestrip>
89+
<ui5-messagestrip class="samples-margin-bottom" type="Negative" no-icon>Negative MessageStrip With No Icon</ui5-messagestrip>
90+
<ui5-messagestrip class="samples-margin-bottom" type="Warning" no-icon>Warning MessageStrip With No Icon</ui5-messagestrip>
9191
</div>
9292
<pre class="prettyprint lang-html"><xmp>
93-
<ui5-messagestrip type="Information" hide-icon>Information MessageStrip With No Icon</ui5-messagestrip>
94-
<ui5-messagestrip type="Positive" hide-icon>Positive MessageStrip With No Icon</ui5-messagestrip>
95-
<ui5-messagestrip type="Negative" hide-icon>Negative MessageStrip With No Icon</ui5-messagestrip>
96-
<ui5-messagestrip type="Warning" hide-icon>Warning MessageStrip With No Icon</ui5-messagestrip>
93+
<ui5-messagestrip type="Information" no-icon>Information MessageStrip With No Icon</ui5-messagestrip>
94+
<ui5-messagestrip type="Positive" no-icon>Positive MessageStrip With No Icon</ui5-messagestrip>
95+
<ui5-messagestrip type="Negative" no-icon>Negative MessageStrip With No Icon</ui5-messagestrip>
96+
<ui5-messagestrip type="Warning" no-icon>Warning MessageStrip With No Icon</ui5-messagestrip>
9797
<script>
9898
document.querySelectorAll("ui5-messagestrip").forEach(function(messageStrip) {
9999
messageStrip.addEventListener("close", function() {
@@ -107,15 +107,15 @@ <h3>MessageStrip With No Icon</h3>
107107
<section>
108108
<h3>Custom MessageStrip</h3>
109109
<div class="snippet">
110-
<ui5-messagestrip class="samples-margin-bottom samples-vertical-align" style="width: 200px;" type="Information" hide-icon no-close-button>You have new message.</ui5-messagestrip>
110+
<ui5-messagestrip class="samples-margin-bottom samples-vertical-align" style="width: 200px;" type="Information" no-icon no-close-button>You have new message.</ui5-messagestrip>
111111
<ui5-messagestrip class="samples-margin-bottom samples-vertical-align" style="width: 200px;" type="Positive" no-close-button>Successfull login!</ui5-messagestrip>
112-
<ui5-messagestrip class="samples-margin-bottom samples-vertical-align" style="width: 200px;" type="Negative" hide-icon>Access denied!</ui5-messagestrip>
112+
<ui5-messagestrip class="samples-margin-bottom samples-vertical-align" style="width: 200px;" type="Negative" no-icon>Access denied!</ui5-messagestrip>
113113
<ui5-messagestrip class="samples-margin-bottom samples-vertical-align" style="width: 200px;" type="Warning">Update is required.</ui5-messagestrip>
114114
</div>
115115
<pre class="prettyprint lang-html"><xmp>
116-
<ui5-messagestrip type="Information" style="width: 200px;" hide-icon no-close-button>You have new message.</ui5-messagestrip>
116+
<ui5-messagestrip type="Information" style="width: 200px;" no-icon no-close-button>You have new message.</ui5-messagestrip>
117117
<ui5-messagestrip type="Positive" style="width: 200px;" no-close-button>Successfull login!</ui5-messagestrip>
118-
<ui5-messagestrip type="Negative" style="width: 200px;" hide-icon>Access denied!</ui5-messagestrip>
118+
<ui5-messagestrip type="Negative" style="width: 200px;" no-icon>Access denied!</ui5-messagestrip>
119119
<ui5-messagestrip type="Warning" style="width: 200px;">Update is required.</ui5-messagestrip>
120120
<script>
121121
document.querySelectorAll("ui5-messagestrip").forEach(function(messageStrip) {

0 commit comments

Comments
 (0)