Skip to content

Commit 2499c56

Browse files
authored
fix(ui5-shellbar-item): Update count properly (#2049)
Fixes #2048
1 parent c6fcf69 commit 2499c56

File tree

3 files changed

+15
-0
lines changed

3 files changed

+15
-0
lines changed

packages/fiori/src/ShellBar.js

+1
Original file line numberDiff line numberDiff line change
@@ -180,6 +180,7 @@ const metadata = {
180180
"default": {
181181
propertyName: "items",
182182
type: HTMLElement,
183+
invalidateParent: true,
183184
},
184185

185186
/**

packages/fiori/test/pages/ShellBar.html

+4
Original file line numberDiff line numberDiff line change
@@ -221,6 +221,10 @@ <h3>ShellBar in Compact</h3>
221221
<ui5-li id="mi-4"slot="menuItems" data-key="key4">App 4</ui5-li>
222222
</ui5-shellbar>
223223

224+
<ui5-shellbar primary-title="UI5 Web Components" id="test-invalidation">
225+
<ui5-shellbar-item icon="discussion" count="2" id="test-invalidation-item"/>
226+
</ui5-shellbar>
227+
224228
<script>
225229
mySearch.addEventListener("suggestionItemSelect", function (event) {
226230
 console.log(event);

packages/fiori/test/specs/ShellBar.spec.js

+10
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,16 @@ describe("Component Behavior", () => {
3131
const icon = shellbar.shadow$("ui5-button[data-count]");
3232

3333
assert.strictEqual(icon.getAttribute("data-count"), '42', "Count property propagates to ui5-button");
34+
});
35+
36+
it("tests if shellbar item invalidates the shellbar", () => {
37+
const shellbar = browser.$("#test-invalidation");
38+
const item = browser.$("#test-invalidation-item");
39+
40+
item.setProperty("count", "3");
41+
42+
assert.strictEqual(shellbar.shadow$(".ui5-shellbar-custom-item").getAttribute("data-count"), "3");
43+
3444
})
3545
});
3646

0 commit comments

Comments
 (0)