Skip to content

Commit 25ed25f

Browse files
authored
fix(ui5-textarea): Add missing dependency, extract .hbs partial (#1909)
1 parent f236e0d commit 25ed25f

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

packages/main/src/TextArea.hbs

+4
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,13 @@
3434
part="textarea">
3535
</textarea>
3636

37+
{{> afterTextarea}}
38+
3739
{{#if showExceededText}}
3840
<span id="{{_id}}-exceededText" class="ui5-textarea-exceeded-text">{{_exceededTextProps.exceededText}}</span>
3941
{{/if}}
4042

4143
<slot name="formSupport"></slot>
4244
</div>
45+
46+
{{#*inline "afterTextarea"}}{{/inline}}

packages/main/src/TextArea.js

+5-1
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import { fetchI18nBundle, getI18nBundle } from "@ui5/webcomponents-base/dist/i18
66
import { getFeature } from "@ui5/webcomponents-base/dist/FeaturesRegistry.js";
77
import { isIE } from "@ui5/webcomponents-base/dist/Device.js";
88
import ValueState from "@ui5/webcomponents-base/dist/types/ValueState.js";
9+
import Popover from "./Popover.js";
910

1011
import TextAreaTemplate from "./generated/templates/TextAreaTemplate.lit.js";
1112
import TextAreaPopoverTemplate from "./generated/templates/TextAreaPopoverTemplate.lit.js";
@@ -585,7 +586,10 @@ class TextArea extends UI5Element {
585586
}
586587

587588
static async onDefine() {
588-
await fetchI18nBundle("@ui5/webcomponents");
589+
await Promise.all([
590+
Popover.define(),
591+
fetchI18nBundle("@ui5/webcomponents"),
592+
]);
589593
}
590594
}
591595

0 commit comments

Comments
 (0)