Skip to content

Commit 27435ee

Browse files
feat(ui5-timeline): implement acc spec (#1471)
1 parent 3665193 commit 27435ee

File tree

4 files changed

+16
-2
lines changed

4 files changed

+16
-2
lines changed

packages/main/src/Timeline.hbs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<div class="ui5-timeline-root">
2-
<ul class="ui5-timeline-list">
2+
<ul class="ui5-timeline-list" role="listbox" aria-live="polite" aria-label="{{ariaLabel}}">
33
{{#each items}}
44
<li class="ui5-timeline-list-item">
55
<slot name="{{this._individualSlot}}"></slot>

packages/main/src/Timeline.js

+11
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
import UI5Element from "@ui5/webcomponents-base/dist/UI5Element.js";
2+
import { fetchI18nBundle, getI18nBundle } from "@ui5/webcomponents-base/dist/i18nBundle.js";
23
import litRender from "@ui5/webcomponents-base/dist/renderer/LitRenderer.js";
34
import ItemNavigation from "@ui5/webcomponents-base/dist/delegate/ItemNavigation.js";
45
import TimelineTemplate from "./generated/templates/TimelineTemplate.lit.js";
6+
import { TIMELINE_ARIA_LABEL } from "./generated/i18n/i18n-defaults.js";
57

68
// Styles
79
import styles from "./generated/themes/Timeline.css.js";
@@ -69,12 +71,21 @@ class Timeline extends UI5Element {
6971
super();
7072

7173
this.initItemNavigation();
74+
this.i18nBundle = getI18nBundle("@ui5/webcomponents");
75+
}
76+
77+
static async onDefine() {
78+
await fetchI18nBundle("@ui5/webcomponents");
7279
}
7380

7481
initItemNavigation() {
7582
this._itemNavigation = new ItemNavigation(this);
7683
this._itemNavigation.getItemsCallback = () => this.items;
7784
}
85+
86+
get ariaLabel() {
87+
return this.i18nBundle.getText(TIMELINE_ARIA_LABEL);
88+
}
7889
}
7990

8091
Timeline.define();

packages/main/src/TimelineItem.hbs

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
</div>
1010
{{/if}}
1111
</div>
12-
<div class="ui5-tli-bubble" tabindex="{{_tabIndex}}" data-sap-focus-ref>
12+
<div class="ui5-tli-bubble" tabindex="{{_tabIndex}}" role="option" data-sap-focus-ref>
1313
<div class="ui5-tli-title">
1414
{{#if itemName}}
1515
{{> itemName}}

packages/main/src/i18n/messagebundle.properties

+3
Original file line numberDiff line numberDiff line change
@@ -268,6 +268,9 @@ TEXTAREA_CHARACTERS_LEFT={0} characters remaining
268268
#XTXT: Text for characters over
269269
TEXTAREA_CHARACTERS_EXCEEDED={0} characters over limit
270270

271+
#XACT: ARIA announcement for timeline label
272+
TIMELINE_ARIA_LABEL=Timeline
273+
271274
#XFLD: Timepicker slider header
272275
TIMEPICKER_HOURS_LABEL=Hours
273276

0 commit comments

Comments
 (0)