Skip to content

Commit 2da6a34

Browse files
authored
feat(ui5-tools): libraries can now control chromedriver version (#1684)
1 parent 8bc6959 commit 2da6a34

File tree

9 files changed

+16
-5
lines changed

9 files changed

+16
-5
lines changed

packages/base/package.json

+1
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
},
3232
"devDependencies": {
3333
"@ui5/webcomponents-tools": "1.0.0-rc.7",
34+
"chromedriver": "latest",
3435
"array-uniq": "^2.0.0",
3536
"copy-and-watch": "^0.1.4",
3637
"eslint": "^5.13.0",

packages/fiori/package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
"@ui5/webcomponents-theme-base": "1.0.0-rc.7"
3232
},
3333
"devDependencies": {
34-
"@ui5/webcomponents-tools": "1.0.0-rc.7"
34+
"@ui5/webcomponents-tools": "1.0.0-rc.7",
35+
"chromedriver": "latest"
3536
}
3637
}

packages/icons/package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
"@ui5/webcomponents-base": "0.20.0"
2525
},
2626
"devDependencies": {
27-
"@ui5/webcomponents-tools": "1.0.0-rc.7"
27+
"@ui5/webcomponents-tools": "1.0.0-rc.7",
28+
"chromedriver": "latest"
2829
}
2930
}

packages/localization/package.json

+1
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
"@buxlabs/amd-to-es6": "^0.15.0",
2626
"@openui5/sap.ui.core": "1.76.0",
2727
"@ui5/webcomponents-tools": "1.0.0-rc.7",
28+
"chromedriver": "latest",
2829
"copy-and-watch": "^0.1.4",
2930
"escodegen": "^1.11.0",
3031
"esprima": "^4.0.1",

packages/main/package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
"@ui5/webcomponents-theme-base": "1.0.0-rc.7"
3232
},
3333
"devDependencies": {
34-
"@ui5/webcomponents-tools": "1.0.0-rc.7"
34+
"@ui5/webcomponents-tools": "1.0.0-rc.7",
35+
"chromedriver": "latest"
3536
}
3637
}

packages/theme-base/package.json

+1
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
},
2929
"devDependencies": {
3030
"@ui5/webcomponents-tools": "1.0.0-rc.7",
31+
"chromedriver": "latest",
3132
"chokidar-cli": "^2.0.0",
3233
"copy-and-watch": "^0.1.4",
3334
"cssnano": "^4.1.10",

packages/tools/lib/init-package/index.js

+3
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,9 @@ const updatePackageFile = () => {
100100
"prepublishOnly": "npm run build"
101101
};
102102

103+
packageContent.devDependencies = packageContent.devDependencies || {};
104+
packageContent.devDependencies["chromedriver"] = "latest";
105+
103106
fs.writeFileSync("package.json", beautify(packageContent, null, 2, 100));
104107
};
105108

packages/tools/package.json

+3-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@
3535
"@webcomponents/webcomponentsjs": "^2.4.0",
3636
"chai": "^4.2.0",
3737
"chokidar-cli": "^2.0.0",
38-
"chromedriver": "^83.0.0",
3938
"clean-css": "^4.2.1",
4039
"command-line-args": "^5.1.1",
4140
"concurrently": "^5.0.0",
@@ -74,6 +73,9 @@
7473
"serve": "^10.1.1",
7574
"wdio-chromedriver-service": "^6.0.2"
7675
},
76+
"peerDependencies": {
77+
"chromedriver": "*"
78+
},
7779
"resolutions": {
7880
"rollup-plugin-livereload/livereload/chokidar": "^3.x"
7981
}

yarn.lock

+1-1
Original file line numberDiff line numberDiff line change
@@ -1996,7 +1996,7 @@ chrome-launcher@^0.13.1:
19961996
mkdirp "^0.5.3"
19971997
rimraf "^3.0.2"
19981998

1999-
chromedriver@^83.0.0:
1999+
chromedriver@latest:
20002000
version "83.0.0"
20012001
resolved "https://registry.yarnpkg.com/chromedriver/-/chromedriver-83.0.0.tgz#75d7d838e58014658c3990089464166fef951926"
20022002
integrity sha512-AePp9ykma+z4aKPRqlbzvVlc22VsQ6+rgF+0aL3B5onHOncK18dWSkLrSSJMczP/mXILN9ohGsvpuTwoRSj6OQ==

0 commit comments

Comments
 (0)