Skip to content

Commit 2e14428

Browse files
authored
refactor: remove ui5-toolbar (#198)
Remove the ui5-toolbar and all affected files and replace it with div element everywhere it is used, including panel and list samples. BREAKING CHANGE: the ui5-toolbar component is removed, we recommend using div or similar HTML tag in combination with flex instead.
1 parent 15eb051 commit 2e14428

38 files changed

+140
-884
lines changed

packages/main/bundle.esm.js

-2
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,6 @@ import Timeline from "./dist/Timeline";
4343
import TimelineItem from "./dist/TimelineItem";
4444
import Title from "./dist/Title";
4545
import ToggleButton from "./dist/ToggleButton";
46-
import Toolbar from "./dist/Toolbar";
47-
import ToolbarSpacer from "./dist/ToolbarSpacer";
4846

4947
import List from "./dist/List";
5048
import StandardListItem from "./dist/StandardListItem";

packages/main/entries-less.esm.js

-8
Original file line numberDiff line numberDiff line change
@@ -118,14 +118,6 @@ import "./src/themes/sap_belize/ToggleButton.less";
118118
import "./src/themes/sap_belize_hcb/ToggleButton.less";
119119
import "./src/themes/sap_fiori_3/ToggleButton.less";
120120

121-
import "./src/themes/sap_belize/Toolbar.less";
122-
import "./src/themes/sap_belize_hcb/Toolbar.less";
123-
import "./src/themes/sap_fiori_3/Toolbar.less";
124-
125-
import "./src/themes/sap_belize/ToolbarSpacer.less";
126-
import "./src/themes/sap_belize_hcb/ToolbarSpacer.less";
127-
import "./src/themes/sap_fiori_3/ToolbarSpacer.less";
128-
129121
import "./src/themes/sap_belize/List.less";
130122
import "./src/themes/sap_belize_hcb/List.less";
131123
import "./src/themes/sap_fiori_3/List.less";

packages/main/src/List.js

+1-3
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,7 @@ const metadata = {
3434
slots: /** @lends sap.ui.webcomponents.main.List.prototype */ {
3535

3636
/**
37-
* Defines the header area.
38-
* For example, you can use <code>ui5-toolbar</code> or any other HTML element.
39-
* <br><br>
37+
* Defines the <code>ui5-li</code> header.
4038
* <b>Note:</b> When <code>header</code> is set, the
4139
* <code>headerText</code> property is ignored.
4240
*

packages/main/src/Panel.js

+1-3
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,6 @@ const metadata = {
3232

3333
/**
3434
* Defines the <code>ui5-panel</code> header area.
35-
* For example, you can use <code>ui5-toolbar</code> and add extra
36-
* components for user interactions.
3735
* <br><br>
3836
* <b>Note:</b> When a header is provided, the <code>headerText</code> property is ignored.
3937
*
@@ -158,7 +156,7 @@ const metadata = {
158156
* </ul>
159157
*
160158
* <h3>Structure</h3>
161-
* A panel consists of a title bar with a header text or header toolbar and a content area.
159+
* A panel consists of a title bar with a header text or custom header.
162160
* <br>
163161
* The content area can contain an arbitrary set of controls.
164162
* The header can contain a title with text and icons, buttons, and a

packages/main/src/Toolbar.hbs

-10
This file was deleted.

packages/main/src/Toolbar.js

-133
This file was deleted.

packages/main/src/ToolbarSpacer.js

-49
This file was deleted.

packages/main/src/ToolbarTemplateContext.js

-44
This file was deleted.

packages/main/src/themes/base/Panel.less

+3-5
Original file line numberDiff line numberDiff line change
@@ -97,17 +97,15 @@ ui5-panel {
9797
position: relative;
9898
}
9999

100-
/* if Panel is expandable, we do not wish toolbar to come with own border */
101-
.sapMPanelWrappingDivTb > .sapMTB {
102-
border-width: 0;
100+
.sapMPanelWrappingDivTb .sapMPanelHdrToolbar {
101+
width: 100%;
103102
}
104103

105104
.sapMPanelWrappingDiv.sapMPanelWrappingDivExpanded {
106105
border-bottom-width: 0;
107106
}
108107

109-
.sapMPanel .sapMPanelWrappingDiv .sapMPanelHdr,
110-
.sapMPanel .sapMPanelWrappingDivTb .sapMIBar.sapMTB {
108+
.sapMPanel .sapMPanelWrappingDiv .sapMPanelHdr {
111109
padding-left: 0;
112110

113111
>:first-child {

0 commit comments

Comments
 (0)