fix(ui5-shellbar): hide notification bubble if empty str (#3123)

ilhan007 · web-flow · commit 33fde82d1b46 · 2021-04-09T10:46:17.000+03:00
The notification bubble used to remain displayed when notification-count is an empty string. Fixes: #3121
diff --git a/packages/fiori/src/themes/ShellBar.css b/packages/fiori/src/themes/ShellBar.css
@@ -326,7 +326,7 @@ slot[name="profile"] {
 	position: relative;
 }
 
-:host([notification-count]) .ui5-shellbar-bell-button::before,
+:host([notification-count]:not([notification-count=""])) .ui5-shellbar-bell-button::before,
 .ui5-shellbar-button[data-count]::before {
 	position: absolute;
 	width: auto;
@@ -347,7 +347,7 @@ slot[name="profile"] {
 	box-sizing: border-box;
 }
 
-:host([notification-count]) .ui5-shellbar-bell-button::before {
+:host([notification-count]:not([notification-count=""])) .ui5-shellbar-bell-button::before {
 	content: attr(data-ui5-notification-count);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -326,7 +326,7 @@ slot[name="profile"] {`
`326`	`326`	`position: relative;`
`327`	`327`	`}`
`328`	`328`
`329`		`-:host([notification-count]) .ui5-shellbar-bell-button::before,`
	`329`	`+:host([notification-count]:not([notification-count=""])) .ui5-shellbar-bell-button::before,`
`330`	`330`	`.ui5-shellbar-button[data-count]::before {`
`331`	`331`	`position: absolute;`
`332`	`332`	`width: auto;`
`@@ -347,7 +347,7 @@ slot[name="profile"] {`
`347`	`347`	`box-sizing: border-box;`
`348`	`348`	`}`
`349`	`349`
`350`		`-:host([notification-count]) .ui5-shellbar-bell-button::before {`
	`350`	`+:host([notification-count]:not([notification-count=""])) .ui5-shellbar-bell-button::before {`
`351`	`351`	`content: attr(data-ui5-notification-count);`
`352`	`352`	`}`
`353`	`353`