Skip to content

Commit 35de38c

Browse files
authored
fix(ui5-upload-collection): add tooltip to edit button (#2886)
1 parent 70bbfbb commit 35de38c

File tree

4 files changed

+11
-2
lines changed

4 files changed

+11
-2
lines changed

packages/fiori/src/UploadCollection.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ const metadata = {
7373

7474
/**
7575
* By default there will be drag and drop overlay shown over the <code>ui5-upload-collection</code> when files
76-
* are dragged. If you don't intend to use drag and drop, set this property to <code>true</code>
76+
* are dragged. If you don't intend to use drag and drop, set this property.
7777
* <br><br>
7878
* <b>Note:</b> It is up to the application developer to add handler for <code>drop</code> event and handle it.
7979
* <code>ui5-upload-collection</code> only shows an overlay.

packages/fiori/src/UploadCollectionItem.hbs

+1
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@
7474
<ui5-button
7575
id="{{_id}}-editing-button"
7676
design="Transparent"
77+
title="{{_editButtonTooltip}}"
7778
icon="edit"
7879
@click="{{onDetailClick}}"
7980
@keyup="{{_onDetailKeyup}}"

packages/fiori/src/UploadCollectionItem.js

+5
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ import {
2222
UPLOADCOLLECTIONITEM_READY_STATE,
2323
UPLOADCOLLECTIONITEM_RETRY_BUTTON_TEXT,
2424
UPLOADCOLLECTIONITEM_TERMINATE_BUTTON_TEXT,
25+
UPLOADCOLLECTIONITEM_EDIT_BUTTON_TEXT,
2526
} from "./generated/i18n/i18n-defaults.js";
2627

2728
// Template
@@ -473,6 +474,10 @@ class UploadCollectionItem extends ListItem {
473474
return this.i18nBundle.getText(UPLOADCOLLECTIONITEM_TERMINATE_BUTTON_TEXT);
474475
}
475476

477+
get _editButtonTooltip() {
478+
return this.i18nBundle.getText(UPLOADCOLLECTIONITEM_EDIT_BUTTON_TEXT);
479+
}
480+
476481
get valueStateName() {
477482
if (this.uploadState === UploadState.Error) {
478483
return "Error";

packages/fiori/src/i18n/messagebundle.properties

+4-1
Original file line numberDiff line numberDiff line change
@@ -84,9 +84,12 @@ UPLOADCOLLECTIONITEM_UPLOADING_STATE=Uploading
8484
#XBUT: Tooltip text for 'Terminate' button in the UploadCollectionItem
8585
UPLOADCOLLECTIONITEM_TERMINATE_BUTTON_TEXT=Terminate
8686

87-
#XBUT: Tooltip text for 'Retrry' button in the UploadCollectionItem
87+
#XBUT: Tooltip text for 'Retry' button in the UploadCollectionItem
8888
UPLOADCOLLECTIONITEM_RETRY_BUTTON_TEXT=Retry
8989

90+
#XBUT: Tooltip text for 'Edit' button in the UploadCollectionItem
91+
UPLOADCOLLECTIONITEM_EDIT_BUTTON_TEXT=Edit
92+
9093
#XMSG: Message text for no data text in the UploadCollection
9194
UPLOADCOLLECTION_NO_DATA_TEXT=No files found.
9295

0 commit comments

Comments
 (0)