Skip to content

Commit 38ffd25

Browse files
authoredApr 16, 2020
fix(ui5-dialog): improve accessibility (#1477)
1 parent 185851a commit 38ffd25

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed
 

‎packages/main/src/Dialog.hbs

+2-2
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<span class="ui5-popup-frame" @focusin="{{_onfocusin}}">
44
<span id="{{_id}}-firstfe" tabindex="0"></span>
55
<div style="{{zindex}}" class="ui5-dialog-root-parent {{classes.dialogParent}}">
6-
<div tabindex="-1" aria-labelledby="{{headerAriaLabelledBy}}" role="dialog" aria-modal="true" class="ui5-popup-root ui5-dialog-root {{classes.dialogParent}}">
6+
<section tabindex="-1" aria-labelledby="{{headerAriaLabelledBy}}" role="dialog" aria-modal="true" class="ui5-popup-root ui5-dialog-root {{classes.dialogParent}}">
77
{{> header}}
88
<section class="ui5-dialog-section">
99
<div class="ui5-popup-content">
@@ -13,7 +13,7 @@
1313
</div>
1414
</section>
1515
{{> footer}}
16-
</div>
16+
</section>
1717
</div>
1818
<span id="{{_id}}-lastfe" tabindex="0"></span>
1919
<div tabindex="0" id="{{_id}}-blocklayer" style="{{blockLayer}}" class="{{classes.blockLayer}}"></div>

‎packages/main/src/Popup.hbs

+2-2
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<slot name="header"></slot>
77
</div>
88
{{else}}
9-
<h2 id="{{_id}}-popup-heading" role="{{role}}" class="ui5-popup-header ui5-popup-headerText">{{headerText}}</h2>
9+
<h2 id="{{_id}}-popup-heading" class="ui5-popup-header ui5-popup-headerText">{{headerText}}</h2>
1010
{{/if}}
1111
</header>
1212
{{/if}}
@@ -15,7 +15,7 @@
1515
{{#*inline "footer"}}
1616
{{#if hasFooter}}
1717
<footer>
18-
<div class="ui5-popup-footer">
18+
<div class="ui5-popup-footer" role="toolbar">
1919
<slot name="footer"></slot>
2020
</div>
2121
</footer>

0 commit comments

Comments
 (0)