Skip to content

Commit 3965a00

Browse files
fifoosidfifoosid
authoredJun 19, 2019
refactor(ui5-link): rename type property to design (#505)
BREAKING CHANGE: property type is renamed to design
·
v./29.5v0.0.0-7b49a7ff1
1 parent 1da36b0 commit 3965a00

File tree

7 files changed

+35
-35
lines changed

7 files changed

+35
-35
lines changed
 

‎packages/main/src/Link.js

+8-8
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import Bootstrap from "@ui5/webcomponents-base/src/Bootstrap.js";
22
import UI5Element from "@ui5/webcomponents-base/src/UI5Element.js";
33
import litRender from "@ui5/webcomponents-base/src/renderer/LitRenderer.js";
44
import { isSpace } from "@ui5/webcomponents-base/src/events/PseudoEvents.js";
5-
import LinkType from "./types/LinkType.js";
5+
import LinkDesign from "./types/LinkDesign.js";
66

77
// Template
88
import LinkRederer from "./build/compiled/LinkTemplate.lit.js";
@@ -60,17 +60,17 @@ const metadata = {
6060
},
6161

6262
/**
63-
* Defines the <code>ui5-link</code> type.
63+
* Defines the <code>ui5-link</code> design.
6464
* <br><br>
6565
* <b>Note:</b> Avaialble options are <code>Default</code>, <code>Subtle</code>, and <code>Emphasized</code>.
6666
*
6767
* @type {string}
6868
* @defaultvalue "Default"
6969
* @public
7070
*/
71-
type: {
72-
type: LinkType,
73-
defaultValue: LinkType.Default,
71+
design: {
72+
type: LinkDesign,
73+
defaultValue: LinkDesign.Default,
7474
},
7575

7676
/**
@@ -137,7 +137,7 @@ const metadata = {
137137
* <br><br>
138138
* To create a visual hierarchy in large lists of links, you can set the less important links as
139139
* <code>Subtle</code> or the more important ones as <code>Emphasized</code>
140-
* by using the <code>type</code> property.
140+
* by using the <code>design</code> property.
141141
* <br><br>
142142
* If the <code>href</code> property is set, the link behaves as the basic HTML
143143
* anchor tag (<code><a></code>) and opens the specified URL in the given target frame (<code>target</code> property).
@@ -252,8 +252,8 @@ class Link extends UI5Element {
252252
return {
253253
main: {
254254
sapMLnk: true,
255-
sapMLnkSubtle: this.type === LinkType.Subtle,
256-
sapMLnkEmphasized: this.type === LinkType.Emphasized,
255+
sapMLnkSubtle: this.design === LinkDesign.Subtle,
256+
sapMLnkEmphasized: this.design === LinkDesign.Emphasized,
257257
sapMLnkWrapping: this.wrap,
258258
sapMLnkDsbl: this.disabled,
259259
sapMLnkMaxWidth: true,

‎packages/main/src/types/LinkType.js renamed to ‎packages/main/src/types/LinkDesign.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,12 @@ const LinkTypes = {
2020
Emphasized: "Emphasized",
2121
};
2222

23-
class LinkType extends DataType {
23+
class LinkDesign extends DataType {
2424
static isValid(value) {
2525
return !!LinkTypes[value];
2626
}
2727
}
2828

29-
LinkType.generataTypeAcessors(LinkTypes);
29+
LinkDesign.generataTypeAcessors(LinkTypes);
3030

31-
export default LinkType;
31+
export default LinkDesign;

‎packages/main/test/sap/ui/webcomponents/main/pages/Kitchen.html

+7-7
Original file line numberDiff line numberDiff line change
@@ -236,19 +236,19 @@
236236
</section>
237237

238238
<section class="row row-centered">
239-
<ui5-link href="https://gmail.com" target="_blank" type="Emphasized">Emphasized</ui5-link>
239+
<ui5-link href="https://gmail.com" target="_blank" design="Emphasized">Emphasized</ui5-link>
240240
<ui5-link href="https://gmail.com" target="_blank">ui5 link</ui5-link>
241-
<ui5-link href="https://gmail.com" target="_blank" type="Subtle">subtle link</ui5-link>
242-
<ui5-link href="https://gmail.com" target="_blank" type="Emphasized">Emphasized</ui5-link>
241+
<ui5-link href="https://gmail.com" target="_blank" design="Subtle">subtle link</ui5-link>
242+
<ui5-link href="https://gmail.com" target="_blank" design="Emphasized">Emphasized</ui5-link>
243243
<ui5-link href="https://gmail.com" target="_blank" disabled>disabled</ui5-link>
244244
<ui5-link href="https://gmail.com" target="_blank">ui5 link</ui5-link>
245-
<ui5-link href="https://gmail.com" target="_blank" type="Emphasized">Emphasized</ui5-link>
245+
<ui5-link href="https://gmail.com" target="_blank" design="Emphasized">Emphasized</ui5-link>
246246
<ui5-link href="https://gmail.com" target="_blank">ui5 link</ui5-link>
247-
<ui5-link href="https://gmail.com" target="_blank" type="Subtle">subtle link</ui5-link>
248-
<ui5-link href="https://gmail.com" target="_blank" type="Emphasized">Emphasized</ui5-link>
247+
<ui5-link href="https://gmail.com" target="_blank" design="Subtle">subtle link</ui5-link>
248+
<ui5-link href="https://gmail.com" target="_blank" design="Emphasized">Emphasized</ui5-link>
249249
<ui5-link href="https://gmail.com" target="_blank">ui5 link</ui5-link>
250250
<ui5-link href="https://gmail.com" target="_blank" disabled>disabled</ui5-link>
251-
<ui5-link href="https://gmail.com" target="_blank" type="Emphasized">Emphasized</ui5-link>
251+
<ui5-link href="https://gmail.com" target="_blank" design="Emphasized">Emphasized</ui5-link>
252252
</section>
253253

254254
<section class="row">

‎packages/main/test/sap/ui/webcomponents/main/pages/Kitchen.openui5.html

+7-7
Original file line numberDiff line numberDiff line change
@@ -231,19 +231,19 @@
231231
</section>
232232

233233
<section class="row row-centered">
234-
<ui5-link href="https://gmail.com" target="_blank" type="Emphasized">Emphasized</ui5-link>
234+
<ui5-link href="https://gmail.com" target="_blank" design="Emphasized">Emphasized</ui5-link>
235235
<ui5-link href="https://gmail.com" target="_blank">ui5 link</ui5-link>
236-
<ui5-link href="https://gmail.com" target="_blank" type="Subtle">subtle link</ui5-link>
237-
<ui5-link href="https://gmail.com" target="_blank" type="Emphasized">Emphasized</ui5-link>
236+
<ui5-link href="https://gmail.com" target="_blank" design="Subtle">subtle link</ui5-link>
237+
<ui5-link href="https://gmail.com" target="_blank" design="Emphasized">Emphasized</ui5-link>
238238
<ui5-link href="https://gmail.com" target="_blank" disabled>disabled</ui5-link>
239239
<ui5-link href="https://gmail.com" target="_blank">ui5 link</ui5-link>
240-
<ui5-link href="https://gmail.com" target="_blank" type="Emphasized">Emphasized</ui5-link>
240+
<ui5-link href="https://gmail.com" target="_blank" design="Emphasized">Emphasized</ui5-link>
241241
<ui5-link href="https://gmail.com" target="_blank">ui5 link</ui5-link>
242-
<ui5-link href="https://gmail.com" target="_blank" type="Subtle">subtle link</ui5-link>
243-
<ui5-link href="https://gmail.com" target="_blank" type="Emphasized">Emphasized</ui5-link>
242+
<ui5-link href="https://gmail.com" target="_blank" design="Subtle">subtle link</ui5-link>
243+
<ui5-link href="https://gmail.com" target="_blank" design="Emphasized">Emphasized</ui5-link>
244244
<ui5-link href="https://gmail.com" target="_blank">ui5 link</ui5-link>
245245
<ui5-link href="https://gmail.com" target="_blank" disabled>disabled</ui5-link>
246-
<ui5-link href="https://gmail.com" target="_blank" type="Emphasized">Emphasized</ui5-link>
246+
<ui5-link href="https://gmail.com" target="_blank" design="Emphasized">Emphasized</ui5-link>
247247
</section>
248248

249249
<section class="row">

‎packages/main/test/sap/ui/webcomponents/main/pages/Link.html

+4-4
Original file line numberDiff line numberDiff line change
@@ -51,10 +51,10 @@ <h2>Wrapping link</h2>
5151
</section>
5252

5353
<section class="group">
54-
<h2>Link types</h2>
55-
<ui5-link type="Default">Eu enim consectetur do amet elit.</ui5-link><br>
56-
<ui5-link type="Subtle">Eu enim consectetur do amet elit.</ui5-link><br>
57-
<ui5-link type="Emphasized">Eu enim consectetur do amet elit.</ui5-link>
54+
<h2>Link designs</h2>
55+
<ui5-link design="Default">Eu enim consectetur do amet elit.</ui5-link><br>
56+
<ui5-link design="Subtle">Eu enim consectetur do amet elit.</ui5-link><br>
57+
<ui5-link design="Emphasized">Eu enim consectetur do amet elit.</ui5-link>
5858
</section>
5959

6060
<section class="group">

‎packages/main/test/sap/ui/webcomponents/main/qunit/Link.qunit.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ TestHelper.ready(function() {
112112
prop: 'target',
113113
value: expectedTarget
114114
}, {
115-
prop: 'type',
115+
prop: 'design',
116116
value: type1
117117
}];
118118

‎packages/main/test/sap/ui/webcomponents/main/samples/Link.sample.html

+5-5
Original file line numberDiff line numberDiff line change
@@ -38,18 +38,18 @@ <h2 class="control-header">Link</h2>
3838
</header>
3939

4040
<section>
41-
<h3>Different Link Types</h3>
41+
<h3>Different Link Designs</h3>
4242
<div class="snippet">
4343
<ui5-link class="samples-big-margin-right" href="https://www.sap.com" target="_blank">Standard Link</ui5-link>
44-
<ui5-link class="samples-big-margin-right" href="https://www.sap.com" target="_blank" type="Subtle">Subtle link</ui5-link>
44+
<ui5-link class="samples-big-margin-right" href="https://www.sap.com" target="_blank" design="Subtle">Subtle link</ui5-link>
4545
<ui5-link class="samples-big-margin-right" href="https://www.sap.com" target="_blank" disabled>Disabled</ui5-link>
46-
<ui5-link class="samples-big-margin-right" href="https://www.sap.com" target="_blank" type="Emphasized">Emphasized</ui5-link>
46+
<ui5-link class="samples-big-margin-right" href="https://www.sap.com" target="_blank" design="Emphasized">Emphasized</ui5-link>
4747
</div>
4848
<pre class="prettyprint lang-html"><xmp>
4949
<ui5-link href="https://www.sap.com" target="_blank">Standard Link</ui5-link>
50-
<ui5-link href="https://www.sap.com" target="_blank" type="Subtle">Subtle link</ui5-link>
50+
<ui5-link href="https://www.sap.com" target="_blank" design="Subtle">Subtle link</ui5-link>
5151
<ui5-link href="https://www.sap.com" target="_blank" disabled>Disabled</ui5-link>
52-
<ui5-link href="https://www.sap.com" target="_blank" type="Emphasized">Emphasized</ui5-link>
52+
<ui5-link href="https://www.sap.com" target="_blank" design="Emphasized">Emphasized</ui5-link>
5353
</xmp></pre>
5454
</section>
5555

0 commit comments

Comments
 (0)
Please sign in to comment.