Skip to content

Commit 3acab5a

Browse files
authoredJun 18, 2020
fix(ui5-avatar): image URL may now contain special characters (#1828)
1 parent fcb2e9e commit 3acab5a

File tree

4 files changed

+15
-2
lines changed

4 files changed

+15
-2
lines changed
 

‎packages/main/src/Avatar.hbs

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
<div class="ui5-avatar-root">
22
{{#if image}}
3-
<span class="ui5-avatar-img" style="background-image: url({{image}})" role="img" aria-label="{{accessibleNameText}}"></span>
3+
<span class="ui5-avatar-img" style="{{styles.img}}" role="img" aria-label="{{accessibleNameText}}"></span>
44
{{else if icon}}
55
<ui5-icon class="ui5-avatar-icon" name="{{icon}}" accessible-name="{{accessibleNameText}}"></ui5-icon>
66
{{else if initials}}
77
<span class="ui5-avatar-initials">{{validInitials}}</span>
88
{{/if}}
9-
</div>
9+
</div>

‎packages/main/src/Avatar.js

+8
Original file line numberDiff line numberDiff line change
@@ -235,6 +235,14 @@ class Avatar extends UI5Element {
235235

236236
return this.i18nBundle.getText(AVATAR_TOOLTIP) || undefined;
237237
}
238+
239+
get styles() {
240+
return {
241+
img: {
242+
"background-image": `url("${encodeURIComponent(this.image)}")`,
243+
},
244+
};
245+
}
238246
}
239247

240248
Avatar.define();

‎packages/main/test/pages/Avatar.html

+5
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,11 @@ <h3>Avatar - Basic sample</h3>
2323
<ui5-avatar image="./img/John_Miller.png"></ui5-avatar>
2424
</section>
2525

26+
<section>
27+
<h3>Avatar - special characters in image path</h3>
28+
<ui5-avatar image="./img/John$$$ ' (_)Miller#1.png"></ui5-avatar>
29+
</section>
30+
2631
<section>
2732
<h3>Avatar - Square [ XS, S, M, L, XL ]</h3>
2833
<ui5-avatar image="./img/woman_avatar_5.png" shape="Square" size="XS"></ui5-avatar>
Loading

0 commit comments

Comments
 (0)
Please sign in to comment.