Skip to content

Commit 4343100

Browse files
authored
refactor(ui5-tabcontainer): deprecate tabsPlacement (#3338)
Hide the tabsPlacement, but keep it working for some time as it is consumed in production, until we introduce the feature on stakeholder's side. Part of: #3107 BREAKING_CHANGE: tabsPlacement has been removed as it is not specified in SAP Fiori 3 design system
1 parent 090e3fc commit 4343100

File tree

3 files changed

+5
-52
lines changed

3 files changed

+5
-52
lines changed

packages/main/src/TabContainer.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ const metadata = {
115115
* @type {TabContainerTabsPlacement}
116116
* @defaultvalue "Top"
117117
* @since 1.0.0-rc.7
118-
* @public
118+
* @private
119119
*/
120120
tabsPlacement: {
121121
type: TabContainerTabsPlacement,

packages/main/src/types/TabContainerTabsPlacement.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -2,19 +2,19 @@ import DataType from "@ui5/webcomponents-base/dist/types/DataType.js";
22

33
/**
44
* @lends sap.ui.webcomponents.main.types.TabContainerTabsPlacement.prototype
5-
* @public
5+
* @private
66
*/
77
const TabContainerTabsPlacements = {
88
/**
99
* The tab strip is displayed above the tab content (Default)
10-
* @public
10+
* @private
1111
* @type {Top}
1212
*/
1313
Top: "Top",
1414

1515
/**
1616
* The tab strip is displayed below the tab content
17-
* @public
17+
* @private
1818
* @type {Bottom}
1919
*/
2020
Bottom: "Bottom",
@@ -26,7 +26,7 @@ const TabContainerTabsPlacements = {
2626
* @constructor
2727
* @author SAP SE
2828
* @alias sap.ui.webcomponents.main.types.TabContainerTabsPlacement
29-
* @public
29+
* @private
3030
* @enum {string}
3131
*/
3232
class TabContainerTabsPlacement extends DataType {

packages/main/test/pages/TabContainer.html

-47
Original file line numberDiff line numberDiff line change
@@ -362,53 +362,6 @@ <h3>TabContainer in Compact</h3>
362362
</div>
363363
</section>
364364

365-
366-
<section>
367-
<h2>tabs-placement=Bottom</h2>
368-
<ui5-tabcontainer show-overflow tabs-placement="Bottom">
369-
<ui5-tab icon="sap-icon://card" selected>
370-
<ui5-button>Button 11</ui5-button>
371-
<ui5-button>Button 12</ui5-button>
372-
</ui5-tab>
373-
<ui5-tab icon="sap-icon://employee">
374-
<ui5-button>Button 3</ui5-button>
375-
</ui5-tab>
376-
<ui5-tab icon="sap-icon://employee">
377-
<ui5-button>Button 3</ui5-button>
378-
</ui5-tab>
379-
<ui5-tab icon="sap-icon://menu2">
380-
<ui5-button>Button 2</ui5-button>
381-
</ui5-tab>
382-
<ui5-tab icon="sap-icon://menu2">
383-
<ui5-button>Button 2</ui5-button>
384-
</ui5-tab>
385-
<ui5-tab icon="sap-icon://employee">
386-
<ui5-button>Button 3</ui5-button>
387-
</ui5-tab>
388-
<ui5-tab icon="sap-icon://employee">
389-
<ui5-button>Button 3</ui5-button>
390-
</ui5-tab>
391-
<ui5-tab icon="sap-icon://employee">
392-
<ui5-button>Button 3</ui5-button>
393-
</ui5-tab>
394-
<ui5-tab icon="sap-icon://employee">
395-
<ui5-button>Button 3</ui5-button>
396-
</ui5-tab>
397-
<ui5-tab icon="sap-icon://employee">
398-
<ui5-button>Button 3</ui5-button>
399-
</ui5-tab>
400-
<ui5-tab icon="sap-icon://employee">
401-
<ui5-button>Button 3</ui5-button>
402-
</ui5-tab>
403-
<ui5-tab icon="sap-icon://menu2">
404-
<ui5-button>Button 2</ui5-button>
405-
</ui5-tab>
406-
<ui5-tab icon="sap-icon://employee">
407-
<ui5-button>Button 3</ui5-button>
408-
</ui5-tab>
409-
</ui5-tabcontainer>
410-
</section>
411-
412365
<section>
413366
<h2>Tab Container With Custom Menu Button</h2>
414367
<ui5-tabcontainer id="tabContainer-custom-icon" fixed collapsed show-overflow>

0 commit comments

Comments
 (0)