fix: Dialog does not break when there is no header text (#1146)

vladitasev · ilhan007 · commit 44e631aaf0ca · 2020-01-21T06:07:41.000+02:00
diff --git a/packages/main/src/Popup.js b/packages/main/src/Popup.js
@@ -445,7 +445,8 @@ class Popup extends UI5Element {
 	}
 
 	get hasHeader() {
-		return !!(this.headerText.length || this.header.length);
+		const hasHeaderText = this.headerText && this.headerText.length;
+		return !!(hasHeaderText || this.header.length);
 	}
 
 	get hasFooter() {

Original file line number	Diff line number	Diff line change
`@@ -445,7 +445,8 @@ class Popup extends UI5Element {`
`445`	`445`	`}`
`446`	`446`
`447`	`447`	`get hasHeader() {`
`448`		`- return !!(this.headerText.length \|\| this.header.length);`
	`448`	`+ const hasHeaderText = this.headerText && this.headerText.length;`
	`449`	`+ return !!(hasHeaderText \|\| this.header.length);`
`449`	`450`	`}`
`450`	`451`
`451`	`452`	`get hasFooter() {`