Skip to content

Commit 52562ec

Browse files
authored
fix(ui5-multi-combobox): adjust storybook sample (#7441)
1 parent 9298747 commit 52562ec

File tree

2 files changed

+18
-32
lines changed

2 files changed

+18
-32
lines changed

packages/main/src/MultiComboBox.ts

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -305,13 +305,6 @@ class MultiComboBox extends UI5Element {
305305
* Defines the value state of the component.
306306
* <br><br>
307307
* Available options are:
308-
* <ul>
309-
* <li><code>None</code></li>
310-
* <li><code>Error</code></li>
311-
* <li><code>Warning</code></li>
312-
* <li><code>Success</code></li>
313-
* <li><code>Information</code></li>
314-
* </ul>
315308
*
316309
* @type {sap.ui.webc.base.types.ValueState}
317310
* @name sap.ui.webc.main.MultiComboBox.prototype.valueState
@@ -377,7 +370,7 @@ class MultiComboBox extends UI5Element {
377370
*
378371
* @type {string}
379372
* @name sap.ui.webc.main.MultiComboBox.prototype.accessibleName
380-
* @defaultvalue: ""
373+
* @defaultvalue ""
381374
* @public
382375
* @since 1.4.0
383376
*/

packages/playground/_stories/main/MultiComboBox/MultiComboBox.stories.ts

Lines changed: 17 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import ValueState from "@ui5/webcomponents-base/dist/types/ValueState.js";
1515
const component = "ui5-multi-combobox";
1616

1717
export default {
18-
title: "Main/MultiComboBox",
18+
title: "Main/Multi-Combo Box",
1919
component: "MultiComboBox",
2020
subcomponents: {'MultiComboBoxItem' : 'MultiComboBoxItem', 'MultiComboBoxGroupItem' : 'MultiComboBoxGroupItem'},
2121
parameters: {
@@ -47,32 +47,24 @@ const Template: UI5StoryArgs<MultiComboBox, StoryArgsSlots> = (args) => html`
4747
</ui5-multi-combobox>`;
4848

4949

50-
export const BasicMultiComboBox = Template.bind({});
51-
BasicMultiComboBox.args = {
50+
export const Basic = Template.bind({});
51+
Basic.args = {
5252
placeholder: 'Type your value',
53-
default: `<ui5-mcb-item selected="" text="UI5"></ui5-mcb-item>`
54-
};
55-
56-
export const MultiComboBoxItems = Template.bind({});
57-
MultiComboBoxItems.args = {
58-
placeholder: 'Choose your countries',
5953
default: `
54+
<ui5-mcb-item text="Albania"></ui5-mcb-item>
6055
<ui5-mcb-item selected="" text="Argentina"></ui5-mcb-item>
6156
<ui5-mcb-item text="Bulgaria"></ui5-mcb-item>
6257
<ui5-mcb-item text="Denmark"></ui5-mcb-item>
6358
<ui5-mcb-item text="England"></ui5-mcb-item>
64-
<ui5-mcb-item text="Albania"></ui5-mcb-item>
65-
<ui5-mcb-item text="Morocco"></ui5-mcb-item>
66-
<ui5-mcb-item text="Portugal"></ui5-mcb-item>
6759
<ui5-mcb-item text="Germany"></ui5-mcb-item>
6860
<ui5-mcb-item text="Philippines"></ui5-mcb-item>
69-
<ui5-mcb-item text="Paraguay"></ui5-mcb-item>`
61+
<ui5-mcb-item text="Portugal"></ui5-mcb-item>
62+
<ui5-mcb-item text="The United Kingdom of Great Britain and Northern Ireland"></ui5-mcb-item>
63+
`
7064
};
7165

72-
MultiComboBoxItems.storyName = "Multi Combo Box with items";
73-
74-
export const MultiComboBoxFreeTextInput = Template.bind({});
75-
MultiComboBoxFreeTextInput.args = {
66+
export const MultiComboBoxCustomValue= Template.bind({});
67+
MultiComboBoxCustomValue.args = {
7668
placeholder: 'Choose your state',
7769
valueState: ValueState.Success,
7870
allowCustomValues: true,
@@ -87,10 +79,10 @@ MultiComboBoxFreeTextInput.args = {
8779
<ui5-mcb-item text="Error"></ui5-mcb-item>
8880
<ui5-mcb-item text="Mistake"></ui5-mcb-item>`
8981
};
90-
MultiComboBoxFreeTextInput.storyName = "Multi Combo Box with free text input";
82+
MultiComboBoxCustomValue.storyName = "Custom Value";
9183

92-
export const MultiComboBoxGroupingItems = Template.bind({});
93-
MultiComboBoxGroupingItems.args = {
84+
export const MultiComboBoxGrouping = Template.bind({});
85+
MultiComboBoxGrouping.args = {
9486
placeholder: 'Select a country',
9587
default: `
9688
<ui5-mcb-group-item text="Asia"></ui5-mcb-group-item>
@@ -103,17 +95,18 @@ MultiComboBoxGroupingItems.args = {
10395
<ui5-mcb-item text="Bulgaria"></ui5-mcb-item>
10496
<ui5-mcb-item text="Germany"></ui5-mcb-item>
10597
<ui5-mcb-item text="Italy"></ui5-mcb-item>
98+
<ui5-mcb-item text="The United Kingdom of Great Britain and Northern Ireland"></ui5-mcb-item>
10699
<ui5-mcb-group-item text="North America"></ui5-mcb-group-item>
107100
<ui5-mcb-item text="Canada"></ui5-mcb-item>
108101
<ui5-mcb-item text="Granada"></ui5-mcb-item>
109102
<ui5-mcb-item text="Haiti"></ui5-mcb-item>
110103
<ui5-mcb-item text="United States"></ui5-mcb-item>`
111104
};
112-
MultiComboBoxGroupingItems.storyName = "Multi Combo Box with Grouping of Items";
105+
MultiComboBoxGrouping.storyName = "Grouping";
113106

114-
export const MultiComboBoxLongText = Template.bind({});
115-
MultiComboBoxLongText.args = {
107+
export const MultiComboBoxLongToken = Template.bind({});
108+
MultiComboBoxLongToken.args = {
116109
placeholder: 'MultiComboBox with single long token',
117110
default: `<ui5-mcb-item selected="" text="Very long long long long long long long text"></ui5-mcb-item>`
118111
};
119-
MultiComboBoxLongText.storyName = "Multi Combo Box with single long token";
112+
MultiComboBoxLongToken.storyName = "Single Long Token";

0 commit comments

Comments
 (0)