fix(ui5-popover): show arrow border (#1528)

ilhan007 · web-flow · commit 56e5ba7146c4 · 2020-04-27T12:52:13.000+03:00
diff --git a/packages/main/src/themes/Popover.css b/packages/main/src/themes/Popover.css
@@ -54,6 +54,7 @@
 	width: 0.7rem;
 	height: 0.7rem;
 	background-color: var(--sapGroup_ContentBackground);
+	box-shadow: var(--sapContent_Shadow2);
 	transform: rotate(-45deg);
 }
 
@@ -66,7 +67,6 @@
 }
 :host([actual-placement-type="Bottom"]) .ui5-popover-arr:after {
 	margin: 0.1875rem 0 0 0.1875rem;
-	box-shadow: -0.375rem 0.375rem 0.75rem 0 var(--_ui5_popover_arrow_shadow_color), 0 0 0.125rem 0 var(--_ui5_popover_arrow_shadow_color);
 }
 
 /* pointing right arrow */
@@ -78,7 +78,6 @@
 
 :host([actual-placement-type="Left"]) .ui5-popover-arr:after {
 	margin: 0.1875rem 0 0 -0.375rem;
-	box-shadow: -0.375rem -0.375rem 0.75rem 0 var(--_ui5_popover_arrow_shadow_color), 0 0 0.125rem 0 var(--_ui5_popover_arrow_shadow_color);
 }
 
 /* pointing downward arrow */
@@ -90,7 +89,6 @@
 
 :host([actual-placement-type="Top"]) .ui5-popover-arr:after {
 	margin: -0.375rem 0 0 0.125rem;
-	box-shadow: 0.375rem -0.375rem 0.75rem 0 var(--_ui5_popover_arrow_shadow_color), 0 0 0.125rem 0 var(--_ui5_popover_arrow_shadow_color);
 }
 
 /* pointing left arrow */
@@ -105,7 +103,6 @@
 :host(:not([actual-placement-type])) .ui5-popover-arr:after,
 :host([actual-placement-type="Right"]) .ui5-popover-arr:after {
 	margin: 0.125rem 0 0 0.25rem;
-	box-shadow: 0.375rem 0.375rem 0.75rem 0 var(--_ui5_popover_arrow_shadow_color), 0 0 0.125rem 0 var(--_ui5_popover_arrow_shadow_color);
 }
 
 :host([no-arrow]) .ui5-popover-arr {
diff --git a/packages/main/src/themes/base/Popover-parameters.css b/packages/main/src/themes/base/Popover-parameters.css
@@ -1,4 +1,3 @@
 :root {
-	--_ui5_popover_arrow_shadow_color:rgba(0,0,0,.3);
 	--_ui5_popover_content_padding: .4375em;
 }
diff --git a/packages/main/src/themes/sap_belize_hcb/Popover-parameters.css b/packages/main/src/themes/sap_belize_hcb/Popover-parameters.css
diff --git a/packages/main/src/themes/sap_belize_hcb/parameters-bundle.css b/packages/main/src/themes/sap_belize_hcb/parameters-bundle.css
@@ -16,7 +16,7 @@
 @import "./MonthPicker-parameters.css";
 @import "./MessageStrip-parameters.css";
 @import "./Panel-parameters.css";
-@import "./Popover-parameters.css";
+@import "../base/Popover-parameters.css";
 @import "./RadioButton-parameters.css";
 @import "./Select-parameters.css";
 @import "./Switch-parameters.css";
diff --git a/packages/main/src/themes/sap_belize_hcw/Popover-parameters.css b/packages/main/src/themes/sap_belize_hcw/Popover-parameters.css
diff --git a/packages/main/src/themes/sap_belize_hcw/parameters-bundle.css b/packages/main/src/themes/sap_belize_hcw/parameters-bundle.css
@@ -16,7 +16,7 @@
 @import "./MonthPicker-parameters.css";
 @import "./MessageStrip-parameters.css";
 @import "./Panel-parameters.css";
-@import "./Popover-parameters.css";
+@import "../base/Popover-parameters.css";
 @import "./RadioButton-parameters.css";
 @import "./Select-parameters.css";
 @import "./Switch-parameters.css";

Original file line number	Diff line number	Diff line change
`@@ -54,6 +54,7 @@`
`54`	`54`	`width: 0.7rem;`
`55`	`55`	`height: 0.7rem;`
`56`	`56`	`background-color: var(--sapGroup_ContentBackground);`
	`57`	`+ box-shadow: var(--sapContent_Shadow2);`
`57`	`58`	`transform: rotate(-45deg);`
`58`	`59`	`}`
`59`	`60`
`@@ -66,7 +67,6 @@`
`66`	`67`	`}`
`67`	`68`	`:host([actual-placement-type="Bottom"]) .ui5-popover-arr:after {`
`68`	`69`	`margin: 0.1875rem 0 0 0.1875rem;`
`69`		`- box-shadow: -0.375rem 0.375rem 0.75rem 0 var(--_ui5_popover_arrow_shadow_color), 0 0 0.125rem 0 var(--_ui5_popover_arrow_shadow_color);`
`70`	`70`	`}`
`71`	`71`
`72`	`72`	`/* pointing right arrow */`
`@@ -78,7 +78,6 @@`
`78`	`78`
`79`	`79`	`:host([actual-placement-type="Left"]) .ui5-popover-arr:after {`
`80`	`80`	`margin: 0.1875rem 0 0 -0.375rem;`
`81`		`- box-shadow: -0.375rem -0.375rem 0.75rem 0 var(--_ui5_popover_arrow_shadow_color), 0 0 0.125rem 0 var(--_ui5_popover_arrow_shadow_color);`
`82`	`81`	`}`
`83`	`82`
`84`	`83`	`/* pointing downward arrow */`
`@@ -90,7 +89,6 @@`
`90`	`89`
`91`	`90`	`:host([actual-placement-type="Top"]) .ui5-popover-arr:after {`
`92`	`91`	`margin: -0.375rem 0 0 0.125rem;`
`93`		`- box-shadow: 0.375rem -0.375rem 0.75rem 0 var(--_ui5_popover_arrow_shadow_color), 0 0 0.125rem 0 var(--_ui5_popover_arrow_shadow_color);`
`94`	`92`	`}`
`95`	`93`
`96`	`94`	`/* pointing left arrow */`
`@@ -105,7 +103,6 @@`
`105`	`103`	`:host(:not([actual-placement-type])) .ui5-popover-arr:after,`
`106`	`104`	`:host([actual-placement-type="Right"]) .ui5-popover-arr:after {`
`107`	`105`	`margin: 0.125rem 0 0 0.25rem;`
`108`		`- box-shadow: 0.375rem 0.375rem 0.75rem 0 var(--_ui5_popover_arrow_shadow_color), 0 0 0.125rem 0 var(--_ui5_popover_arrow_shadow_color);`
`109`	`106`	`}`
`110`	`107`
`111`	`108`	`:host([no-arrow]) .ui5-popover-arr {`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,3 @@`
`1`	`1`	`:root {`
`2`		`- --_ui5_popover_arrow_shadow_color:rgba(0,0,0,.3);`
`3`	`2`	`--_ui5_popover_content_padding: .4375em;`
`4`	`3`	`}`