Skip to content

Commit 57be7c2

Browse files
authored
fix(ui5-flexible-column-layout): Fix arrow misplacement in IE (#2032)
Fixes: #1998
1 parent 7f99be5 commit 57be7c2

File tree

3 files changed

+15
-1
lines changed

3 files changed

+15
-1
lines changed

packages/fiori/src/FlexibleColumnLayout.hbs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<div class="ui5-fcl-root">
1+
<div class="{{classes.root}}">
22
<div
33
role="region"
44
class="{{classes.columns.start}}"

packages/fiori/src/FlexibleColumnLayout.js

+5
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import Integer from "@ui5/webcomponents-base/dist/types/Integer.js";
66
import { fetchI18nBundle, getI18nBundle } from "@ui5/webcomponents-base/dist/i18nBundle.js";
77
import AnimationMode from "@ui5/webcomponents-base/dist/types/AnimationMode.js";
88
import { getAnimationMode } from "@ui5/webcomponents-base/dist/config/AnimationMode.js";
9+
import { isIE } from "@ui5/webcomponents-base/dist/Device.js";
910
import Button from "@ui5/webcomponents/dist/Button.js";
1011
import "@ui5/webcomponents-icons/dist/icons/slim-arrow-left.js";
1112
import "@ui5/webcomponents-icons/dist/icons/slim-arrow-right.js";
@@ -490,6 +491,10 @@ class FlexibleColumnLayout extends UI5Element {
490491
const hasAnimation = getAnimationMode() !== AnimationMode.None;
491492

492493
return {
494+
root: {
495+
"ui5-fcl-root": true,
496+
"ui5-fcl--ie": isIE(),
497+
},
493498
columns: {
494499
start: {
495500
"ui5-fcl-column": true,

packages/fiori/src/themes/FlexibleColumnLayout.css

+9
Original file line numberDiff line numberDiff line change
@@ -100,3 +100,12 @@
100100
.ui5-fcl-arrow:hover:after {
101101
height: 7rem;
102102
}
103+
104+
/*
105+
* IE FIX:
106+
* The column separator, that is also the arrow container, is 1rem,
107+
* whereas the arrow button is 1.5rem and the arrows just doesnt center within the
108+
*/
109+
.ui5-fcl--ie .ui5-fcl-arrow {
110+
margin: 0 -0.75rem;
111+
}

0 commit comments

Comments
 (0)