Skip to content

Commit 580e289

Browse files
authored
feat(ui5-checkbox): add support for "Success" value state (#3278)
Add support for "Success" value state Fixes: #3198 Closes: #3198
1 parent 922ab70 commit 580e289

File tree

3 files changed

+16
-3
lines changed

3 files changed

+16
-3
lines changed

packages/main/src/CheckBox.js

+8-3
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,11 @@ import { isSpace, isEnter } from "@ui5/webcomponents-base/dist/Keys.js";
99
import "@ui5/webcomponents-icons/dist/accept.js";
1010
import Icon from "./Icon.js";
1111
import Label from "./Label.js";
12-
import { VALUE_STATE_ERROR, VALUE_STATE_WARNING } from "./generated/i18n/i18n-defaults.js";
12+
import {
13+
VALUE_STATE_ERROR,
14+
VALUE_STATE_WARNING,
15+
VALUE_STATE_SUCCESS,
16+
} from "./generated/i18n/i18n-defaults.js";
1317

1418
// Template
1519
import CheckBoxTemplate from "./generated/templates/CheckBoxTemplate.lit.js";
@@ -88,8 +92,8 @@ const metadata = {
8892
* <li><code>Warning</code></li>
8993
* <li><code>Error</code></li>
9094
* <li><code>None</code>(default)</li>
91-
* <li><code>Negative</code></li>
92-
* <li><code>Transparent</code></li>
95+
* <li><code>Success</code></li>
96+
* <li><code>Information</code></li>
9397
* </ul>
9498
*
9599
* @type {ValueState}
@@ -321,6 +325,7 @@ class CheckBox extends UI5Element {
321325
return {
322326
"Error": i18nBundle.getText(VALUE_STATE_ERROR),
323327
"Warning": i18nBundle.getText(VALUE_STATE_WARNING),
328+
"Success": i18nBundle.getText(VALUE_STATE_SUCCESS),
324329
};
325330
}
326331

packages/main/src/themes/CheckBox.css

+7
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,13 @@
6767
color: var(--sapField_InformationColor);
6868
}
6969

70+
:host([value-state="Success"]) .ui5-checkbox-inner,
71+
:host([value-state="Success"]) .ui5-checkbox--hoverable:hover .ui5-checkbox-inner {
72+
background: var(--sapField_SuccessBackground);
73+
border: var(--_ui5_checkbox_inner_success_border);
74+
color: var(--sapField_SuccessColor);
75+
}
76+
7077
:host([value-state="Warning"]) .ui5-checkbox-icon {
7178
color: var(--_ui5_checkbox_checkmark_warning_color);
7279
}

packages/main/src/themes/base/CheckBox-parameters.css

+1
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
--_ui5_checkbox_inner_error_border: 0.125rem solid var(--sapField_InvalidColor);
99
--_ui5_checkbox_inner_warning_border: 0.125rem solid var(--sapField_WarningColor);
1010
--_ui5_checkbox_inner_information_border: 0.125rem solid var(--sapField_InformationColor);
11+
--_ui5_checkbox_inner_success_border: var(--sapField_BorderWidth) solid var(--sapField_SuccessColor);
1112
--_ui5_checkbox_inner_readonly_border: 0.125rem solid var(--sapField_ReadOnly_BorderColor);
1213
--_ui5_checkbox_checkmark_warning_color: var(--sapField_TextColor);
1314
--_ui5_checkbox_checkmark_color: var(--sapSelectedColor);

0 commit comments

Comments
 (0)