Skip to content

Commit 5898eb8

Browse files
authoredJun 8, 2021
fix(ui5-upload-collection): change file deleted event name (#3413)
Part of #3107 BREAKING_CHANGE: The "file-deleted "event" is renamed to "item-delete"
1 parent 6104b80 commit 5898eb8

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed
 

‎packages/fiori/src/UploadCollection.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -150,11 +150,11 @@ const metadata = {
150150
* <br><br>
151151
* <b>Note:</b> A Delete button is displayed on each item,
152152
* when the <code>ui5-upload-collection</code> <code>mode</code> property is set to <code>Delete</code>.
153-
* @event sap.ui.webcomponents.fiori.UploadCollection#file-deleted
153+
* @event sap.ui.webcomponents.fiori.UploadCollection#item-delete
154154
* @param {HTMLElement} item The <code>ui5-upload-collection-item</code> which was renamed.
155155
* @public
156156
*/
157-
"file-deleted": {
157+
"item-delete": {
158158
detail: {
159159
item: { type: HTMLElement },
160160
},
@@ -294,7 +294,7 @@ class UploadCollection extends UI5Element {
294294
}
295295

296296
_onItemDelete(event) {
297-
this.fireEvent("file-deleted", { item: event.detail.item });
297+
this.fireEvent("item-delete", { item: event.detail.item });
298298
}
299299

300300
_onSelectionChange(event) {

‎packages/fiori/test/pages/uploadCollectionScript.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@
6565
document.getElementById("fileUploader").value = "";
6666
});
6767

68-
uploadCollection.addEventListener("ui5-selectionChange", function (event) {
68+
uploadCollection.addEventListener("ui5-selection-change", function (event) {
6969
var selectedItems = event.detail.selectedItems.reduce(function (acc, item) {
7070
return acc + item.fileName + ",";
7171
}, "[");
@@ -75,7 +75,7 @@
7575
document.getElementById("selectedItems").innerText = selectedItems;
7676
});
7777

78-
uploadCollection.addEventListener("ui5-fileDeleted", function (event) {
78+
uploadCollection.addEventListener("ui5-item-delete", function (event) {
7979
uploadCollection.removeChild(event.detail.item)
8080
});
8181

‎packages/fiori/test/specs/UploadCollection.spec.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ describe("UploadCollection", () => {
6464
assert.strictEqual(parseInt(browser.$("#renamedFileIndex").getText()), secondItemIndex, "renamed file index should be updated after rename")
6565
});
6666

67-
it("upload collection should fire 'fileDeleted'", () => {
67+
it("upload collection should fire 'item-delete'", () => {
6868
const uploadCollection = browser.$("#uploadCollection");
6969
const firstItem = browser.$("#firstItem");
7070

@@ -75,7 +75,7 @@ describe("UploadCollection", () => {
7575
const deleteBtn = firstItem.shadow$(".ui5-li-deletebtn");
7676
deleteBtn.click();
7777

78-
assert.strictEqual(uploadCollection.getProperty("items").length, 4, "item should be deleted when 'fileDeleted' event is fired");
78+
assert.strictEqual(uploadCollection.getProperty("items").length, 4, "item should be deleted when 'item-delete' event is fired");
7979
});
8080

8181
it("item should fire 'retry'", () => {

0 commit comments

Comments
 (0)
Please sign in to comment.