fix(ui5-list): remove focus trap for empty list (#2411)

fifoosid · web-flow · commit 5f8e0e268dab · 2020-11-30T17:37:54.000+02:00
diff --git a/packages/main/src/List.hbs b/packages/main/src/List.hbs
@@ -14,7 +14,9 @@
 		</header>
 	{{/if}}
 
-	<div id="{{_id}}-before" tabindex="0" class="ui5-list-focusarea"></div>
+	{{#if hasData}}
+		<div id="{{_id}}-before" tabindex="0" class="ui5-list-focusarea"></div>
+	{{/if}}
 
 	<ul id="{{_id}}-listUl"
 		class="ui5-list-ul"
@@ -46,5 +48,7 @@
 		</div>
 	{{/if}}
 
-	<div id="{{_id}}-after" tabindex="0" class="ui5-list-focusarea"></div>
+	{{#if hasData}}
+		<div id="{{_id}}-after" tabindex="0" class="ui5-list-focusarea"></div>
+	{{/if}}
 </div>
diff --git a/packages/main/src/List.js b/packages/main/src/List.js
@@ -381,8 +381,12 @@ class List extends UI5Element {
 		return `${this._id}-header`;
 	}
 
+	get hasData() {
+		return this.items.length !== 0;
+	}
+
 	get showNoDataText() {
-		return this.items.length === 0 && this.noDataText;
+		return !this.hasData && this.noDataText;
 	}
 
 	get showBusy() {

Original file line number	Diff line number	Diff line change
`@@ -381,8 +381,12 @@ class List extends UI5Element {`
`381`	`381`	return `${this._id}-header`;
`382`	`382`	`}`
`383`	`383`
	`384`	`+ get hasData() {`
	`385`	`+ return this.items.length !== 0;`
	`386`	`+ }`
	`387`	`+`
`384`	`388`	`get showNoDataText() {`
`385`		`- return this.items.length === 0 && this.noDataText;`
	`389`	`+ return !this.hasData && this.noDataText;`
`386`	`390`	`}`
`387`	`391`
`388`	`392`	`get showBusy() {`