Skip to content

Commit 6172005

Browse files
authored
fix(ui5-messagestrip): add RTL support (#1741)
FIXES: #1739
1 parent 9b4b6c4 commit 6172005

File tree

2 files changed

+34
-7
lines changed

2 files changed

+34
-7
lines changed

packages/main/src/MessageStrip.hbs

+8-7
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,18 @@
11
<div class="{{classes.main}}"
22
id="{{_id}}"
33
role="alert"
4+
dir="{{effectiveDir}}"
45
aria-live="assertive"
56
aria-labelledby="{{_id}}">
67

78
{{#unless noIcon}}
8-
<div class="ui5-messagestrip-icon-wrapper">
9-
{{#if iconProvided}}
10-
<slot name="icon"></slot>
11-
{{else}}
12-
<ui5-icon name="{{standardIconName}}" class="ui5-messagestrip-icon"></ui5-icon>
13-
{{/if}}
14-
</div>
9+
<div class="ui5-messagestrip-icon-wrapper">
10+
{{#if iconProvided}}
11+
<slot name="icon"></slot>
12+
{{else}}
13+
<ui5-icon name="{{standardIconName}}" class="ui5-messagestrip-icon"></ui5-icon>
14+
{{/if}}
15+
</div>
1516
{{/unless}}
1617

1718
<span class="ui5-hidden-text">{{hiddenText}}</span>

packages/main/src/themes/MessageStrip.css

+26
Original file line numberDiff line numberDiff line change
@@ -133,3 +133,29 @@
133133
.ui5-messagestrip-close-icon-wrapper::-moz-focus-inner {
134134
border: none;
135135
}
136+
137+
/* RTL */
138+
.ui5-messagestrip-root[dir="rtl"] {
139+
padding-right: 2.5rem;
140+
padding-left: 2rem;
141+
}
142+
143+
[dir="rtl"] .ui5-messagestrip-icon-wrapper {
144+
right: 0.75rem;
145+
left: 0;
146+
}
147+
148+
[dir="rtl"] .ui5-messagestrip-icon--hidden {
149+
padding-right: 1rem;
150+
padding-left: 2rem;
151+
}
152+
153+
[dir="rtl"] .ui5-messagestrip-close-icon--hidden {
154+
padding-left: 1rem;
155+
padding-right: 0;
156+
}
157+
158+
[dir="rtl"] .ui5-messagestrip-close-icon-wrapper {
159+
left: 0.125rem;
160+
right: auto;
161+
}

0 commit comments

Comments
 (0)