Skip to content

Commit 64fef90

Browse files
authored
fix(ui5-li): correct truncation behaviour of info text (#2330)
Fixes: #2317
1 parent c84bc8b commit 64fef90

File tree

3 files changed

+46
-21
lines changed

3 files changed

+46
-21
lines changed

packages/main/src/StandardListItem.hbs

+13-5
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,26 @@
11
{{>include "./ListItem.hbs"}}
22

33
{{#*inline "listItemContent"}}
4-
<div class="ui5-li-title-wrapper">
4+
<div class="ui5-li-text-wrapper">
55
<span part="title" class="ui5-li-title"><slot></slot></span>
66
{{#if description}}
7-
<span part="description" class="ui5-li-desc">{{description}}</span>
7+
<div class="ui5-li-description-info-wrapper">
8+
<span part="description" class="ui5-li-desc">{{description}}</span>
9+
10+
{{#if info}}
11+
<span part="info" class="ui5-li-info">{{info}}</span>
12+
{{/if}}
13+
</div>
814
{{/if}}
915
{{#unless typeActive}}
1016
<span class="ui5-hidden-text">{{type}}</span>
1117
{{/unless}}
1218
</div>
13-
{{#if info}}
14-
<span part="info" class="ui5-li-info">{{info}}</span>
15-
{{/if}}
19+
{{#unless description}}
20+
{{#if info}}
21+
<span part="info" class="ui5-li-info">{{info}}</span>
22+
{{/if}}
23+
{{/unless}}
1624
{{/inline}}
1725

1826
{{#*inline "imageBegin"}}
+18-10
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,33 @@
11
{{>include "./StandardListItem.hbs"}}
22

33
{{#*inline "listItemContent"}}
4-
<div class="ui5-li-title-wrapper">
4+
<div class="ui5-li-text-wrapper">
55
{{#if hasTitle}}
66
<span part="title" class="ui5-li-title"><slot></slot></span>
77
{{/if}}
88
{{#if hasDescription}}
9-
<span part="description" class="ui5-li-desc">
10-
{{#if richDescription.length}}
11-
<slot name="richDescription"></slot>
12-
{{else}}
13-
{{description}}
9+
<div class="ui5-li-description-info-wrapper">
10+
<span part="description" class="ui5-li-desc">
11+
{{#if richDescription.length}}
12+
<slot name="richDescription"></slot>
13+
{{else}}
14+
{{description}}
15+
{{/if}}
16+
</span>
17+
18+
{{#if info}}
19+
<span part="info" class="ui5-li-info">{{info}}</span>
1420
{{/if}}
15-
</span>
21+
</div>
1622
{{/if}}
1723
{{#unless typeActive}}
1824
<span class="ui5-hidden-text">{{type}}</span>
1925
{{/unless}}
2026
</div>
21-
{{#if info}}
22-
<span part="info" class="ui5-li-info">{{info}}</span>
23-
{{/if}}
27+
{{#unless hasDescription}}
28+
{{#if info}}
29+
<span part="info" class="ui5-li-info">{{info}}</span>
30+
{{/if}}
31+
{{/unless}}
2432
{{/inline}}
2533

packages/main/src/themes/ListItem.css

+15-6
Original file line numberDiff line numberDiff line change
@@ -81,25 +81,31 @@
8181
padding-bottom: 0.375rem;
8282
}
8383

84-
.ui5-li-title-wrapper {
84+
.ui5-li-text-wrapper {
8585
display: flex;
8686
flex-direction: column;
8787
flex: auto;
8888
min-width: 1px;
8989
line-height: normal;
9090
}
9191

92-
:host([description]) .ui5-li-title-wrapper {
92+
:host([description]) .ui5-li-text-wrapper {
9393
height: 100%;
9494
justify-content: space-between;
9595
padding: 0.125rem 0;
9696
}
9797

98+
.ui5-li-description-info-wrapper {
99+
display: flex;
100+
justify-content: space-between;
101+
}
102+
98103
.ui5-li-title {
99104
color: var(--sapTextColor);
100105
font-size: var(--_ui5_list_item_title_size);
101106
}
102107

108+
.ui5-li-info,
103109
.ui5-li-title,
104110
.ui5-li-desc {
105111
white-space: nowrap;
@@ -116,10 +122,9 @@
116122
margin: 0 0.25rem;
117123
color: var(--sapNeutralTextColor);
118124
font-size: 0.875rem;
119-
flex-shrink: 0;
120-
overflow: hidden;
121-
text-overflow: ellipsis;
122-
white-space: nowrap;
125+
min-width: 6rem;
126+
text-align: right;
127+
max-width: 40%;
123128
}
124129

125130
:host([description]) .ui5-li-info {
@@ -201,6 +206,10 @@
201206
margin: .5rem 0 .5rem 0.75rem;
202207
}
203208

209+
[dir="rtl"] .ui5-li-info {
210+
text-align: left;
211+
}
212+
204213
:host([_mode="SingleSelectBegin"]) [dir="rtl"].ui5-li-root {
205214
padding-right: 0;
206215
padding-left: 1rem;

0 commit comments

Comments
 (0)