Skip to content

Commit 658328a

Browse files
author
GerganaKremenska
authored
fix(ui5-side-navigation): items in popup fire click event (#3468)
1 parent 62977d0 commit 658328a

File tree

2 files changed

+17
-4
lines changed

2 files changed

+17
-4
lines changed

packages/fiori/src/SideNavigation.js

+1
Original file line numberDiff line numberDiff line change
@@ -227,6 +227,7 @@ class SideNavigation extends UI5Element {
227227
const listItem = event.detail.item;
228228
const item = listItem.associatedItem;
229229

230+
item.fireEvent("click");
230231
if (item.selected) {
231232
return;
232233
}

packages/fiori/test/specs/SideNavigation.spec.js

+16-4
Original file line numberDiff line numberDiff line change
@@ -50,18 +50,30 @@ describe("Component Behavior", () => {
5050

5151
items[0].click();
5252

53-
assert.strictEqual(input.getProperty("value"), "6", "Event is fired");
53+
assert.strictEqual(input.getProperty("value"), "7", "Event is fired");
5454

5555
items[3].click();
5656

57-
assert.strictEqual(input.getProperty("value"), "6", "Event is not fired");
57+
assert.strictEqual(input.getProperty("value"), "7", "Event is not fired");
5858
assert.strictEqual(items[3].getAttribute("expanded"), "true", "Expanded is toggled");
5959

6060
items[3].click();
6161

62-
assert.strictEqual(input.getProperty("value"), "6", "Event is not fired");
62+
assert.strictEqual(input.getProperty("value"), "7", "Event is not fired");
6363
assert.strictEqual(items[3].getAttribute("expanded"), "false", "Expanded is toggled");
64-
});
64+
65+
items[1].click();
66+
assert.strictEqual(input.getProperty("value"), "8", "Event is fired");
67+
68+
const staticAreaItemClassName = browser.getStaticAreaItemClassName("#sn1");
69+
const popover = browser.$(`.${staticAreaItemClassName}`).shadow$("ui5-responsive-popover");
70+
items = popover.$("ui5-list").$$("ui5-li");
71+
72+
items[1].click();
73+
74+
assert.strictEqual(input.getProperty("value"), "9", "Event is fired");
75+
76+
});
6577

6678
it("Tests header visibility", () => {
6779
let showHeader = null;

0 commit comments

Comments
 (0)