Skip to content

Commit 6790647

Browse files
authored
fix(ui5-textarea): fix text vertical alignment (#1668)
Issue: when growing and growing-max-lines="1" are set the text in the input field is a little downwards and not vertically centred. Now it is fixed and the new metrics for padding and height are the ones the openui5 TextArea uses. FIXES: #1661
1 parent c48f541 commit 6790647

File tree

3 files changed

+29
-2
lines changed

3 files changed

+29
-2
lines changed

packages/main/src/themes/TextArea.css

+3-2
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@
3939

4040
.ui5-textarea-root {
4141
height: 100%;
42+
min-height: var(--_ui5_input_height);
4243
display: inline-flex;
4344
vertical-align: top;
4445
outline: none;
@@ -52,7 +53,7 @@
5253
width: 100%;
5354
height: 100%;
5455
margin: 0;
55-
padding: 0.5625rem 0.6875rem;
56+
padding: var(--_ui5_textarea_padding);
5657
line-height: 1.4;
5758
box-sizing: border-box;
5859
color: inherit;
@@ -85,7 +86,7 @@
8586
visibility: hidden;
8687
width: 100%;
8788
word-break: break-all;
88-
padding: 0.5625rem 0.6875rem;
89+
padding: var(--_ui5_textarea_padding);
8990
font-size: var(--sapFontSize);
9091
font-family: var(--sapFontFamily);
9192
white-space: pre-wrap;

packages/main/src/themes/base/sizes-parameters.css

+6
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,9 @@
5656
--_ui5_tc_item_icon_size: 1.5rem;
5757
--_ui5_tc_item_add_text_margin_top: 0.625rem;
5858

59+
/* TextArea */
60+
--_ui5_textarea_padding: 0.5625rem 0.6875rem;
61+
5962
/* Responsive Popover */
6063
--_ui5-responnsive_popover_header_height: 2.75rem;
6164

@@ -113,6 +116,9 @@
113116
--_ui5_input_icon_padding: .25rem .5rem;
114117
--_ui5_input_value_state_icon_padding: .1875rem .5rem;
115118

119+
/* TextArea */
120+
--_ui5_textarea_padding: .1875rem .5rem;
121+
116122
/* List */
117123
--_ui5_list_no_data_height: 2rem;
118124
--_ui5_list_item_cb_margin_right: .5rem;

packages/main/test/pages/TextArea.html

+20
Original file line numberDiff line numberDiff line change
@@ -179,6 +179,26 @@
179179
</ui5-textarea>
180180
</section>
181181

182+
<section class="group">
183+
<ui5-title>Growing: growing-max-lines="1"</ui5-title>
184+
<br>
185+
<ui5-textarea growing growing-max-lines="1"></ui5-textarea>
186+
187+
<ui5-title>Growing: growing-max-lines="4"</ui5-title>
188+
<br>
189+
<ui5-textarea growing growing-max-lines="4"></ui5-textarea>
190+
</section>
191+
192+
<section class="group sapUiSizeCompact">
193+
<ui5-title>Growing: growing-max-lines="1" (compact)</ui5-title>
194+
<br>
195+
<ui5-textarea growing growing-max-lines="1"></ui5-textarea>
196+
197+
<ui5-title>Growing: growing-max-lines="4" (compact)</ui5-title>
198+
<br>
199+
<ui5-textarea growing growing-max-lines="4"></ui5-textarea>
200+
</section>
201+
182202
<script>
183203
var changeCounter = 0;
184204
var inputCounter = 0;

0 commit comments

Comments
 (0)