Skip to content

Commit 6cd3da8

Browse files
authored
fix(ui5-combobox): translate accessibleName (#1563)
1 parent 51ac193 commit 6cd3da8

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

packages/main/src/ComboBox.hbs

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
?pressed="{{_iconPressed}}"
3434
@click="{{_arrowClick}}"
3535
dir="{{dir}}"
36-
accessibleName="{{_accessibleNameText}}"
36+
accessibleName="{{_iconAccessibleNameText}}"
3737
></ui5-icon>
3838
{{/unless}}
3939
</div>

packages/main/src/ComboBox.js

+5
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ import {
1313
VALUE_STATE_ERROR,
1414
VALUE_STATE_WARNING,
1515
INPUT_SUGGESTIONS_TITLE,
16+
ICON_ACCESSIBLE_NAME,
1617
} from "./generated/i18n/i18n-defaults.js";
1718

1819
// Templates
@@ -479,6 +480,10 @@ class ComboBox extends UI5Element {
479480
return this.i18nBundle.getText(INPUT_SUGGESTIONS_TITLE);
480481
}
481482

483+
get _iconAccessibleNameText() {
484+
return this.i18nBundle.getText(ICON_ACCESSIBLE_NAME);
485+
}
486+
482487
get inner() {
483488
return isPhone() ? this.responsivePopover.querySelector(".ui5-input-inner-phone") : this.shadowRoot.querySelector("[inner-input]");
484489
}

0 commit comments

Comments
 (0)