Skip to content

Commit 70bbfbb

Browse files
authoredFeb 26, 2021
fix(framework): adapt ie11 package for usage in modern browsers (#2878)
1 parent 583f5f0 commit 70bbfbb

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed
 

‎packages/base/src/DOMObserver.js

+6-2
Original file line numberDiff line numberDiff line change
@@ -21,15 +21,19 @@ let _destroyObserver = observer => {
2121
* @param createFn
2222
*/
2323
const setCreateObserverCallback = createFn => {
24-
_createObserver = createFn;
24+
if (typeof createFn === "function") {
25+
_createObserver = createFn;
26+
}
2527
};
2628

2729
/**
2830
* Allows to create an alternative DOM observer implementation
2931
* @param destroyFn
3032
*/
3133
const setDestroyObserverCallback = destroyFn => {
32-
_destroyObserver = destroyFn;
34+
if (typeof destroyFn === "function") {
35+
_destroyObserver = destroyFn;
36+
}
3337
};
3438

3539
/**

‎packages/ie11/src/integrate.js

+4-2
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,10 @@ attachThemeLoaded(runPonyfill);
1818
attachBeforeComponentRender(createComponentStyleTag);
1919

2020
// Set the custom DOM observer implementation for observe/unobserve
21-
setCreateObserverCallback(window.ShadyDOM.observeChildren);
22-
setDestroyObserverCallback(window.ShadyDOM.unobserveChildren);
21+
const observeChildrenMethod = window.ShadyDOM ? window.ShadyDOM.observeChildren : undefined;
22+
const unobserveChildrenMethod = window.ShadyDOM ? window.ShadyDOM.unobserveChildren : undefined;
23+
setCreateObserverCallback(observeChildrenMethod);
24+
setDestroyObserverCallback(unobserveChildrenMethod);
2325

2426
// Set the custom Resize observer implementation for observe/unobserve
2527
setResizeHandlerObserveFn(customObserve);

0 commit comments

Comments
 (0)
Please sign in to comment.