Skip to content

Commit 746f907

Browse files
authored
fix(ui5-information): fix component visual (#1498)
- fix type="Information" appearance, by setting the correct varialbes, previously the "neutral" semantic variables has been used - fix the icons colors in all types, they used to remain grey (their default color), instead of being in the respective semantic color according to the component type FIXES: #1496
1 parent ae7b395 commit 746f907

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

packages/main/src/MessageStrip.hbs

+2-2
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,11 @@
55
aria-labelledby="{{_id}}">
66

77
{{#unless noIcon}}
8-
<div class="ui5-messagestrip-icon">
8+
<div class="ui5-messagestrip-icon-wrapper">
99
{{#if iconProvided}}
1010
<slot name="icon"></slot>
1111
{{else}}
12-
<ui5-icon name="{{standardIconName}}"></ui5-icon>
12+
<ui5-icon name="{{standardIconName}}" class="ui5-messagestrip-icon"></ui5-icon>
1313
{{/if}}
1414
</div>
1515
{{/unless}}

packages/main/src/themes/MessageStrip.css

+4-4
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
position: relative;
1919
}
2020

21-
.ui5-messagestrip-root .ui5-messagestrip-icon {
21+
.ui5-messagestrip-root .ui5-messagestrip-icon-wrapper {
2222
position: absolute;
2323
top: var(--_ui5_messagestrip_icon_top);
2424
left: 0.75rem;
@@ -45,13 +45,13 @@
4545
}
4646

4747
.ui5-messagestrip--info {
48-
background-color: var(--sapNeutralBackground);
49-
border-color: var(--sapNeutralColor);
48+
background-color: var(--sapInformationBackground);
49+
border-color: var(--sapInformationBorderColor);
5050
color: var(--sapTextColor);
5151
}
5252

5353
.ui5-messagestrip--info .ui5-messagestrip-icon {
54-
color: var(--sapNeutralElementColor);
54+
color: var(--sapInformativeElementColor);
5555
}
5656

5757
.ui5-messagestrip--positive {

0 commit comments

Comments
 (0)