Skip to content

Commit 76bf9f3

Browse files
authoredApr 9, 2019
fix(ui5-li-custom): enable setting height of the custom content (#311)
Fixes: #310
1 parent f24f78b commit 76bf9f3

File tree

2 files changed

+15
-6
lines changed

2 files changed

+15
-6
lines changed
 

‎packages/main/src/themes-next/CustomListItem.css

+9
Original file line numberDiff line numberDiff line change
@@ -15,14 +15,23 @@ ui5-li-custom .sap-phone .sapMLIB {
1515
}
1616

1717
.sapMLIB.sapMCustomLI {
18+
height: 100%;
1819
padding: 0;
1920
}
2021

22+
ui5-checkbox.multiSelectionCheckBox,
23+
ui5-radiobutton.singleSelectionRadioButton {
24+
display: flex;
25+
align-items: center;
26+
}
27+
28+
.sapMLIB.sapMCustomLI,
2129
ui5-checkbox.multiSelectionCheckBox,
2230
ui5-radiobutton.singleSelectionRadioButton {
2331
min-width: 3rem;
2432
}
2533

34+
.sapUiSizeCompact .sapMLIB.sapMCustomLI,
2635
.sapUiSizeCompact ui5-checkbox.multiSelectionCheckBox,
2736
.sapUiSizeCompact ui5-radiobutton.singleSelectionRadioButton {
2837
min-width: 2rem;

‎packages/main/test/sap/ui/webcomponents/main/pages/Kitchen.html

+6-6
Original file line numberDiff line numberDiff line change
@@ -390,19 +390,19 @@
390390
<section class="row">
391391
<ui5-list header-text="Products" mode="SingleSelectEnd">
392392
<ui5-li-custom type="Active">
393-
<div style="width: 100%; height: 3rem; display: flex; align-items: center; justify-content: space-between">
393+
<div style="width: 100%; height: 5rem; display: flex; align-items: center; justify-content: space-between">
394394
<span>Laptop HP 2GB RAM Dual-core</span>
395395
<ui5-link>Go to SAP</ui5-link>
396396
</div>
397397
</ui5-li-custom>
398398
<ui5-li-custom type="Active">
399-
<div style="width: 100%; height: 3rem; display: flex; align-items: center; justify-content: space-between">
399+
<div style="width: 100%; height: 5rem; display: flex; align-items: center; justify-content: space-between">
400400
<span>Laptop HP 2GB RAM Dual-core</span>
401401
<ui5-link>Go to SAP</ui5-link>
402402
</div>
403403
</ui5-li-custom>
404404
<ui5-li-custom type="Active">
405-
<div style="width: 100%; height: 3rem; display: flex; align-items: center; justify-content: space-between">
405+
<div style="width: 100%; height: 5rem; display: flex; align-items: center; justify-content: space-between">
406406
<span>Laptop HP 2GB RAM Dual-core</span>
407407
<ui5-link>Go to SAP</ui5-link>
408408
</div>
@@ -411,19 +411,19 @@
411411

412412
<ui5-list header-text="Products" mode="MultiSelect">
413413
<ui5-li-custom type="Active">
414-
<div style="width: 100%; height: 3rem; display: flex; align-items: center; justify-content: space-between">
414+
<div style="width: 100%; height: 8rem; display: flex; align-items: center; justify-content: space-between">
415415
<span>Laptop HP 2GB RAM Dual-core</span>
416416
<ui5-link>Go to SAP</ui5-link>
417417
</div>
418418
</ui5-li-custom>
419419
<ui5-li-custom type="Active">
420-
<div style="width: 100%; height: 3rem; display: flex; align-items: center; justify-content: space-between">
420+
<div style="width: 100%; height: 8rem; display: flex; align-items: center; justify-content: space-between">
421421
<span>Laptop HP 2GB RAM Dual-core</span>
422422
<ui5-link>Go to SAP</ui5-link>
423423
</div>
424424
</ui5-li-custom>
425425
<ui5-li-custom type="Active">
426-
<div style="width: 100%; height: 3rem; display: flex; align-items: center; justify-content: space-between">
426+
<div style="width: 100%; height: 8rem; display: flex; align-items: center; justify-content: space-between">
427427
<span>Laptop HP 2GB RAM Dual-core</span>
428428
<ui5-link>Go to SAP</ui5-link>
429429
</div>

0 commit comments

Comments
 (0)
Please sign in to comment.