Skip to content

Commit 77cabba

Browse files
authored
fix: lists no longer show a dot on IE (#2011)
Despite having the right CSS style, for some reason it is not applied on IE until the component is repainted by the browser. Now, there are no dots already on the first load.
1 parent ad30db8 commit 77cabba

10 files changed

+13
-8
lines changed

packages/fiori/src/NotificationListGroupItem.hbs

+1
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
tabindex="{{_tabIndex}}"
88
dir="{{effectiveDir}}"
99
aria-labelledby="{{ariaLabelledBy}}"
10+
style="list-style-type: none;"
1011
>
1112
<div class="ui5-nli-group-header">
1213
<ui5-button

packages/fiori/src/NotificationListItem.hbs

+1
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
tabindex="{{_tabIndex}}"
1010
dir="{{effectiveDir}}"
1111
aria-labelledby="{{ariaLabelledBy}}"
12+
style="list-style-type: none;"
1213
>
1314
<div class="ui5-nli-actions">
1415
{{#if showOverflow}}

packages/main/src/GroupHeaderListItem.hbs

+1
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
@focusout="{{_onfocusout}}"
66
@keydown="{{_onkeydown}}"
77
role="option"
8+
style="list-style-type: none;"
89
>
910
<span class="ui5-hidden-text">{{groupHeaderText}}</span>
1011

packages/main/src/List.hbs

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
<slot></slot>
2727

2828
{{#if showNoDataText}}
29-
<li id="{{_id}}-nodata" class="ui5-list-nodata" tabindex="{{noDataTabIndex}}">
29+
<li id="{{_id}}-nodata" class="ui5-list-nodata" tabindex="{{noDataTabIndex}}" style="list-style-type: none;">
3030
<div id="{{_id}}-nodata-text" class="ui5-list-nodata-text">
3131
{{noDataText}}
3232
</div>

packages/main/src/ListItem.hbs

+1
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
role="{{_accInfo.role}}"
1616
aria-expanded="{{_accInfo.ariaExpanded}}"
1717
aria-level="{{_accInfo.ariaLevel}}"
18+
style="list-style-type: none;"
1819
>
1920
{{> listItemPreContent}}
2021

packages/main/src/TabContainer.hbs

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
{{this.stripPresentation}}
2424
{{/unless}}
2525
{{#if this.isSeparator}}
26-
<li id="{{this._id}}" role="separator" class="{{../classes.separator}}"></li>
26+
<li id="{{this._id}}" role="separator" class="{{../classes.separator}}" style="list-style-type: none;"></li>
2727
{{/if}}
2828
{{/each}}
2929
</ul>

packages/main/src/TabInStrip.hbs

+1
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
?disabled="{{this.effectiveDisabled}}"
1111
aria-labelledby="{{this.ariaLabelledBy}}"
1212
data-ui5-stable="{{this.stableDomRef}}"
13+
style="list-style-type: none;"
1314
>
1415

1516
{{#if this.icon}}

packages/main/src/TabSeparator.hbs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
<li id="{{_id}}" role="separator"></li>
1+
<li id="{{_id}}" role="separator" style="list-style-type: none;"></li>

packages/main/src/Timeline.hbs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<div class="ui5-timeline-root">
22
<ul class="ui5-timeline-list" role="listbox" aria-live="polite" aria-label="{{ariaLabel}}">
33
{{#each items}}
4-
<li class="ui5-timeline-list-item">
4+
<li class="ui5-timeline-list-item" style="list-style-type: none;">
55
<slot name="{{this._individualSlot}}"></slot>
66
</li>
77
{{/each}}

packages/main/src/WheelSlider.hbs

+4-4
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<div
1+
<div
22
id="{{this._id}}"
33
?disabled= "{{disabled}}"
44
value = "{{value}}"
@@ -25,17 +25,17 @@
2525
{{#if _expanded}}
2626
<ul id="{{this._id}}--items-list">
2727
{{#each _itemsToShow}}
28-
<li class="ui5-wheelslider-item" data-item-index="{{@index}}">{{this}}</li>
28+
<li class="ui5-wheelslider-item" data-item-index="{{@index}}" style="list-style-type: none;">{{this}}</li>
2929
{{/each}}
3030
</ul>
3131
{{else}}
3232
<ul id="{{this._id}}--items-list">
33-
<li class="ui5-wheelslider-item">{{value}}</li>
33+
<li class="ui5-wheelslider-item" style="list-style-type: none;">{{value}}</li>
3434
</ul>
3535
{{/if}}
3636
</div>
3737
</div>
3838
<div class="ui5-wheelslider-footer-block">
3939
<ui5-button class="ui5-wheelslider-arrow" icon="navigation-down-arrow" @click={{_onArrowDown}} tabindex="-1"></ui5-button>
4040
</div>
41-
</div>
41+
</div>

0 commit comments

Comments
 (0)