fix(ui5-dialog): Fix aria-labelledby attribute value (#3044)

TeodorTaushanov · ilhan007 · commit 7bc18be7efc8 · 2021-03-31T12:52:09.000+03:00
FIXES: #2946
diff --git a/packages/main/src/Dialog.hbs b/packages/main/src/Dialog.hbs
@@ -9,7 +9,7 @@
 			{{#if header.length }}
 				<slot name="header"></slot>
 			{{else}}
-				<h2 class="ui5-popup-header-text">{{headerText}}</h2>
+				<h2 id="ui5-popup-header-text" class="ui5-popup-header-text">{{headerText}}</h2>
 			{{/if}}
 		</header>
 	{{/if}}
diff --git a/packages/main/src/Dialog.js b/packages/main/src/Dialog.js
@@ -204,7 +204,7 @@ class Dialog extends Popup {
 	}
 
 	get _ariaLabelledBy() { // Required by Popup.js
-		return this.ariaLabel ? undefined : "ui5-popup-header";
+		return (this.ariaLabel || this.header.length) ? undefined : "ui5-popup-header-text";
 	}
 
 	get _ariaModal() { // Required by Popup.js

Original file line number	Diff line number	Diff line change
`@@ -204,7 +204,7 @@ class Dialog extends Popup {`
`204`	`204`	`}`
`205`	`205`
`206`	`206`	`get _ariaLabelledBy() { // Required by Popup.js`
`207`		`- return this.ariaLabel ? undefined : "ui5-popup-header";`
	`207`	`+ return (this.ariaLabel \|\| this.header.length) ? undefined : "ui5-popup-header-text";`
`208`	`208`	`}`
`209`	`209`
`210`	`210`	`get _ariaModal() { // Required by Popup.js`