Skip to content

Commit 83a88af

Browse files
authored
fix(ui5-responsive-popover): fix header styles (#3176)
We use lit-html classMaps to render classes out of objects , but it works with this getter "get classes()" not with any getters. FIXES: #3173
1 parent 023945a commit 83a88af

File tree

3 files changed

+18
-7
lines changed

3 files changed

+18
-7
lines changed

packages/main/src/ResponsivePopover.hbs

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
{{#if header.length}}
1414
<slot slot="header" name="header"></slot>
1515
{{else}}
16-
<header class="{{dialogClasses.header}}">
16+
<header class="{{classes.header}}">
1717
{{#if headerText }}
1818
<ui5-title level="H2" class="ui5-popup-header-text ui5-responsive-popover-header-text">{{headerText}}</ui5-title>
1919
{{/if}}

packages/main/src/ResponsivePopover.js

+8-6
Original file line numberDiff line numberDiff line change
@@ -90,13 +90,15 @@ class ResponsivePopover extends Popover {
9090
return [Popover.styles, ResponsivePopoverCss];
9191
}
9292

93-
get dialogClasses() {
94-
return {
95-
header: {
96-
"ui5-responsive-popover-header": true,
97-
"ui5-responsive-popover-header-no-title": !this.headerText,
98-
},
93+
get classes() {
94+
const allClasses = super.classes;
95+
96+
allClasses.header = {
97+
"ui5-responsive-popover-header": true,
98+
"ui5-responsive-popover-header-no-title": !this.headerText,
9999
};
100+
101+
return allClasses;
100102
}
101103

102104
static get template() {

packages/main/test/pages/ResponsivePopover.html

+9
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,11 @@ <h2> Inputs based component that opens popover/dialog within dialog</h2>
9494
<ui5-date-picker></ui5-date-picker>
9595
</ui5-dialog>
9696

97+
<ui5-button id="btnSimpleRP">Open Simple RP</ui5-button>
98+
<ui5-responsive-popover id="simpleRP">
99+
Content
100+
</ui5-responsive-popover>
101+
97102
<script>
98103
btnOpen.addEventListener("click", function(event) {
99104
respPopover.open(btnOpen);
@@ -118,6 +123,10 @@ <h2> Inputs based component that opens popover/dialog within dialog</h2>
118123
btnOpenDialog.addEventListener('click', function (event) {
119124
dialog.open(btnOpenDialog);
120125
});
126+
127+
btnSimpleRP.addEventListener("click", function(event) {
128+
simpleRP.open(btnSimpleRP);
129+
});
121130
</script>
122131
</body>
123132
</html>

0 commit comments

Comments
 (0)