Skip to content

Commit 8cba688

Browse files
authored
fix(ui5-popover): Calculate max content height (#3386)
Resolves #3131 This fix steps on the following commit: e35cc1a It enhances it in a way that Popover.MIN_OFFSET is taken into account into Popover's maxContentHeight. Popover.MIN_OFFSET is used when calculating the offset of the Popover from the top, but has never been extracted from the content's height.
1 parent 0ecb3c8 commit 8cba688

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

packages/main/src/Popover.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -562,7 +562,7 @@ class Popover extends Popup {
562562
}
563563
}
564564

565-
this._maxContentHeight = maxContentHeight;
565+
this._maxContentHeight = maxContentHeight - Popover.MIN_OFFSET;
566566

567567
const arrowPos = this.getArrowPosition(targetRect, popoverSize, left, top, isVertical);
568568

0 commit comments

Comments
 (0)