fix(ui5-shellbar): pass correct values for events details

Martin R. Hristov · Martin R. Hristov · commit 8dae5bf5c2e3 · 2019-04-03T13:40:16.000+03:00
fixes: #297
diff --git a/packages/main/src/ShellBar.js b/packages/main/src/ShellBar.js
@@ -609,7 +609,9 @@ class ShellBar extends WebComponent {
 	}
 
 	_handleNotificationsPress(event) {
-		this.fireEvent("notificationsPress");
+		this.fireEvent("notificationsPress", {
+			iconRef: this.shadowRoot.querySelector(".sapWCShellBarBellIcon"),
+		});
 	}
 
 	_handleProfilePress(event) {
@@ -620,7 +622,7 @@ class ShellBar extends WebComponent {
 
 	_handleProductSwitchPress(event) {
 		this.fireEvent("productSwitchPress", {
-			detail: this.shadowRoot.querySelector(".sapWCShellBarIconProductSwitch"),
+			iconRef: this.shadowRoot.querySelector(".sapWCShellBarIconProductSwitch"),
 		});
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -609,7 +609,9 @@ class ShellBar extends WebComponent {`
`609`	`609`	`}`
`610`	`610`
`611`	`611`	`_handleNotificationsPress(event) {`
`612`		`- this.fireEvent("notificationsPress");`
	`612`	`+ this.fireEvent("notificationsPress", {`
	`613`	`+ iconRef: this.shadowRoot.querySelector(".sapWCShellBarBellIcon"),`
	`614`	`+ });`
`613`	`615`	`}`
`614`	`616`
`615`	`617`	`_handleProfilePress(event) {`
`@@ -620,7 +622,7 @@ class ShellBar extends WebComponent {`
`620`	`622`
`621`	`623`	`_handleProductSwitchPress(event) {`
`622`	`624`	`this.fireEvent("productSwitchPress", {`
`623`		`- detail: this.shadowRoot.querySelector(".sapWCShellBarIconProductSwitch"),`
	`625`	`+ iconRef: this.shadowRoot.querySelector(".sapWCShellBarIconProductSwitch"),`
`624`	`626`	`});`
`625`	`627`	`}`
`626`	`628`