fix(ui5-select): make disabled select not focusable (#2229)

fifoosid · web-flow · commit 960f927be379 · 2020-09-23T07:53:41.000+03:00
diff --git a/packages/main/src/Select.js b/packages/main/src/Select.js
@@ -579,8 +579,8 @@ class Select extends UI5Element {
 
 	get tabIndex() {
 		return this.disabled
-		&& this.responsivePopover // Handles focus on Tab/Shift + Tab when the popover is opened
-		&& this.responsivePopover.opened ? "-1" : "0";
+		|| (this.responsivePopover // Handles focus on Tab/Shift + Tab when the popover is opened
+		&& this.responsivePopover.opened) ? "-1" : "0";
 	}
 
 	get classes() {

Original file line number	Diff line number	Diff line change
`@@ -579,8 +579,8 @@ class Select extends UI5Element {`
`579`	`579`
`580`	`580`	`get tabIndex() {`
`581`	`581`	`return this.disabled`
`582`		`- && this.responsivePopover // Handles focus on Tab/Shift + Tab when the popover is opened`
`583`		`- && this.responsivePopover.opened ? "-1" : "0";`
	`582`	`+ \|\| (this.responsivePopover // Handles focus on Tab/Shift + Tab when the popover is opened`
	`583`	`+ && this.responsivePopover.opened) ? "-1" : "0";`
`584`	`584`	`}`
`585`	`585`
`586`	`586`	`get classes() {`