Skip to content

Commit 973a80d

Browse files
authored
fix(ui5-select): remove aria-roledescription (#2463)
The reledescription prevents its role of button to be read by JAWS. Fixes #2358
1 parent 2b9008c commit 973a80d

File tree

3 files changed

+0
-9
lines changed

3 files changed

+0
-9
lines changed

packages/main/src/Select.hbs

-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
aria-disabled="{{isDisabled}}"
1212
aria-required="{{required}}"
1313
aria-expanded="{{_isPickerOpen}}"
14-
aria-roledescription="{{selectRoleDescription}}"
1514
@keydown="{{_onkeydown}}"
1615
@keyup="{{_onkeyup}}"
1716
@focusin="{{_onfocusin}}"

packages/main/src/Select.js

-5
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ import {
2424
VALUE_STATE_ERROR,
2525
VALUE_STATE_WARNING,
2626
INPUT_SUGGESTIONS_TITLE,
27-
SELECT_ROLE_DESCRIPTION,
2827
} from "./generated/i18n/i18n-defaults.js";
2928
import Option from "./Option.js";
3029
import Label from "./Label.js";
@@ -561,10 +560,6 @@ class Select extends UI5Element {
561560
return this.disabled || undefined;
562561
}
563562

564-
get selectRoleDescription() {
565-
return this.i18nBundle.getText(SELECT_ROLE_DESCRIPTION);
566-
}
567-
568563
get _headerTitleText() {
569564
return this.i18nBundle.getText(INPUT_SUGGESTIONS_TITLE);
570565
}

packages/main/src/i18n/messagebundle.properties

-3
Original file line numberDiff line numberDiff line change
@@ -286,9 +286,6 @@ RATING_INDICATOR_TEXT=Rating Indicator
286286
#XACT: ARIA description for the segmented button
287287
SEGMENTEDBUTTON_ARIA_DESCRIPTION=Segmented button
288288

289-
#XACT: ARIA announcement for the Select`s roledescription attribute
290-
SELECT_ROLE_DESCRIPTION=Select
291-
292289
#XACT: ARIA announcement for the switch on
293290
SWITCH_ON=On
294291

0 commit comments

Comments
 (0)