Skip to content

Commit 9d83806

Browse files
authored
fix(ui5-date-picker): select date with SPACE on keyup (#2279)
This PR complements the following PR #2276 to fix everything requested by the referenced issue, more specifically forcing date selection with SPACE to take place on keyup, instead of keydown as at the moment. FIXES: #2268
1 parent fac40a8 commit 9d83806

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

packages/main/src/DayPicker.hbs

+1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
class="ui5-dp-root"
33
style="{{styles.wrapper}}"
44
@keydown={{_onkeydown}}
5+
@keyup={{_onkeyup}}
56
@mousedown={{_onmousedown}}
67
@mouseup={{_onmouseup}}
78
>

packages/main/src/DayPicker.js

+8-1
Original file line numberDiff line numberDiff line change
@@ -453,7 +453,8 @@ class DayPicker extends UI5Element {
453453
}
454454

455455
if (isSpace(event)) {
456-
return this._handleSpace(event);
456+
event.preventDefault();
457+
return;
457458
}
458459

459460
if (isHomeCtrl(event)) {
@@ -481,6 +482,12 @@ class DayPicker extends UI5Element {
481482
}
482483
}
483484

485+
_onkeyup(event) {
486+
if (isSpace(event)) {
487+
this._handleSpace(event);
488+
}
489+
}
490+
484491
_handleEnter(event) {
485492
event.preventDefault();
486493
if (event.target.className.indexOf("ui5-dp-item") > -1) {

0 commit comments

Comments
 (0)