Skip to content

Commit 9edb5de

Browse files
authored
fix(framework): reliably re-render lists of DOM nodes (#1519)
1 parent c26e8aa commit 9edb5de

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

packages/main/test/specs/ComboBox.spec.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ describe("General interaction", () => {
2525
const input = combo.shadow$("#ui5-combobox-input");
2626
const staticAreaItemClassName = browser.getStaticAreaItemClassName("#combo");
2727
const popover = browser.$(`.${staticAreaItemClassName}`).shadow$("ui5-responsive-popover");
28-
const listItems = popover.$("ui5-list").$$("ui5-li");
2928

3029
input.click();
3130
input.keys("b");
@@ -40,6 +39,7 @@ describe("General interaction", () => {
4039

4140
assert.strictEqual(selection, "ahrain", "ahrain should be selected");
4241
assert.strictEqual(combo.getProperty("value"), "Bulgaria", "Value should be Bulgaria");
42+
const listItems = popover.$("ui5-list").$$("ui5-li");
4343
assert.ok(listItems[0].getProperty("selected"), "List Item should be selected");
4444

4545
lazy.click();
@@ -169,4 +169,4 @@ describe("General interaction", () => {
169169
listItems = popover.$("ui5-list").$$("ui5-li");
170170
assert.strictEqual(listItems.length, 0, "Items should be 0");
171171
});
172-
});
172+
});

packages/tools/lib/hbs2lit/src/litVisitor2.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ function visitEachBlock(block) {
135135
var bParamAdded = false;
136136
visitSubExpression.call(this, block);
137137

138-
this.blocks[this.currentKey()] += "${ repeat(" + normalizePath.call(this, block.params[0].original) + ", undefined, (item, index) => ";
138+
this.blocks[this.currentKey()] += "${ repeat(" + normalizePath.call(this, block.params[0].original) + ", (item, index) => item._id || index, (item, index) => ";
139139
this.paths.push(normalizePath.call(this, block.params[0].original));
140140
this.blockPath = "item";
141141

0 commit comments

Comments
 (0)