fix: fix HCB colours for Icon, TextArea and TableCell content (#128)

ilhan007 · web-flow · commit 9fb7dc5a5688 · 2019-03-05T17:18:46.000+02:00
diff --git a/packages/main/src/themes/base/Icon.less b/packages/main/src/themes/base/Icon.less
@@ -13,12 +13,14 @@
 :host(ui5-icon) {
 	display: inline-block;
 	outline: none;
+	color: @sapUiContentNonInteractiveIconColor;
 }
 
 // required for browsers without native shadow dom
 ui5-icon {
 	display: inline-block;
 	outline: none;
+	color: @sapUiContentNonInteractiveIconColor;
 
 	// workaround for IE
 	// pressing on the span does not propagate active state to the web component
diff --git a/packages/main/src/themes/base/TableCell.less b/packages/main/src/themes/base/TableCell.less
@@ -9,12 +9,14 @@
 	display: inline-block;
 	width: 100%;
 	height: 100%;
+	color: @sapUiContentLabelColor;
 }
 
 ui5-table-cell {
 	display: inline-block;
 	width: 100%;
 	height: 100%;
+	color: @sapUiContentLabelColor;
 }
 
 .sapWCTableCell {
diff --git a/packages/main/src/themes/base/TextArea.less b/packages/main/src/themes/base/TextArea.less
@@ -142,6 +142,7 @@ ui5-textarea {
 		overflow: hidden;
 		align-self: flex-end;
 		padding: 0.125rem 0.125rem 0.5rem;
+		color: @sapUiContentLabelColor;
 		font-family: @sapUiFontFamily;
 		font-size: @sapMFontSmallSize;
 	}
diff --git a/packages/main/test/sap/ui/webcomponents/main/samples/Table.sample.html b/packages/main/test/sap/ui/webcomponents/main/samples/Table.sample.html
@@ -45,6 +45,9 @@
 		display: none;
 	}
 
+	.hcb-background .headerToolbar {
+		color: #fff;
+	}
 	</style>
 </head>
 <body class="sapUiBody example-wrapper">

Original file line number	Diff line number	Diff line change
`@@ -9,12 +9,14 @@`
`9`	`9`	`display: inline-block;`
`10`	`10`	`width: 100%;`
`11`	`11`	`height: 100%;`
	`12`	`+ color: @sapUiContentLabelColor;`
`12`	`13`	`}`
`13`	`14`
`14`	`15`	`ui5-table-cell {`
`15`	`16`	`display: inline-block;`
`16`	`17`	`width: 100%;`
`17`	`18`	`height: 100%;`
	`19`	`+ color: @sapUiContentLabelColor;`
`18`	`20`	`}`
`19`	`21`
`20`	`22`	`.sapWCTableCell {`
Original file line number	Diff line number	Diff line change
`@@ -142,6 +142,7 @@ ui5-textarea {`
`142`	`142`	`overflow: hidden;`
`143`	`143`	`align-self: flex-end;`
`144`	`144`	`padding: 0.125rem 0.125rem 0.5rem;`
	`145`	`+ color: @sapUiContentLabelColor;`
`145`	`146`	`font-family: @sapUiFontFamily;`
`146`	`147`	`font-size: @sapMFontSmallSize;`
`147`	`148`	`}`
Original file line number	Diff line number	Diff line change
`@@ -45,6 +45,9 @@`
`45`	`45`	`display: none;`
`46`	`46`	`}`
`47`	`47`
	`48`	`+ .hcb-background .headerToolbar {`
	`49`	`+ color: #fff;`
	`50`	`+ }`
`48`	`51`	`</style>`
`49`	`52`	`</head>`
`50`	`53`	`<body class="sapUiBody example-wrapper">`