Skip to content

Commit a00225c

Browse files
MapTo0MapTo0
authoredMay 22, 2020
fix(ui5-dialog): restrict max height and width based on spec (#1665)
FIXES: #1662
·
v./29.5v0.0.0-7b49a7ff1
1 parent d00b0be commit a00225c

File tree

3 files changed

+56
-1
lines changed

3 files changed

+56
-1
lines changed
 

‎packages/main/src/themes/Dialog.css

+5
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,11 @@
1515
height: 100%;
1616
}
1717

18+
:host([stretch][on-phone]) .ui5-popup-root {
19+
max-height: 100vh;
20+
max-width: 100vw;
21+
}
22+
1823
.ui5-popup-root {
1924
display: flex;
2025
flex-direction: column;

‎packages/main/src/themes/Popup.css

+2
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@
1818
display: flex;
1919
flex-direction: column;
2020
overflow: hidden;
21+
max-height: 94vh;
22+
max-width: 90vw;
2123
}
2224

2325
@media screen and (-ms-high-contrast: active) {

‎packages/main/test/pages/Dialog.html

+49-1
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,54 @@
4343
<ui5-dialog id="msg-dialog" header-text="Message dialog">
4444
<p>Build enterprise-ready web applications, responsive to all devices and running on the browser of your choice.
4545
That´s OpenUI5.</p>
46+
<p>Build enterprise-ready web applications, responsive to all devices and running on the browser of your choice.
47+
That´s OpenUI5.</p>
48+
<p>Build enterprise-ready web applications, responsive to all devices and running on the browser of your choice.
49+
That´s OpenUI5.</p>
50+
<p>Build enterprise-ready web applications, responsive to all devices and running on the browser of your choice.
51+
That´s OpenUI5.</p>
52+
<p>Build enterprise-ready web applications, responsive to all devices and running on the browser of your choice.
53+
That´s OpenUI5.</p>
54+
<p>Build enterprise-ready web applications, responsive to all devices and running on the browser of your choice.
55+
That´s OpenUI5.</p>
56+
<p>Build enterprise-ready web applications, responsive to all devices and running on the browser of your choice.
57+
That´s OpenUI5.</p>
58+
<p>Build enterprise-ready web applications, responsive to all devices and running on the browser of your choice.
59+
That´s OpenUI5.</p>
60+
<p>Build enterprise-ready web applications, responsive to all devices and running on the browser of your choice.
61+
That´s OpenUI5.</p>
62+
<p>Build enterprise-ready web applications, responsive to all devices and running on the browser of your choice.
63+
That´s OpenUI5.</p>
64+
<p>Build enterprise-ready web applications, responsive to all devices and running on the browser of your choice.
65+
That´s OpenUI5.</p>
66+
<p>Build enterprise-ready web applications, responsive to all devices and running on the browser of your choice.
67+
That´s OpenUI5.</p>
68+
<p>Build enterprise-ready web applications, responsive to all devices and running on the browser of your choice.
69+
That´s OpenUI5.</p>
70+
<p>Build enterprise-ready web applications, responsive to all devices and running on the browser of your choice.
71+
That´s OpenUI5.</p>
72+
<p>Build enterprise-ready web applications, responsive to all devices and running on the browser of your choice.
73+
That´s OpenUI5.</p>
74+
<p>Build enterprise-ready web applications, responsive to all devices and running on the browser of your choice.
75+
That´s OpenUI5.</p>
76+
<p>Build enterprise-ready web applications, responsive to all devices and running on the browser of your choice.
77+
That´s OpenUI5.</p>
78+
<p>Build enterprise-ready web applications, responsive to all devices and running on the browser of your choice.
79+
That´s OpenUI5.</p>
80+
<p>Build enterprise-ready web applications, responsive to all devices and running on the browser of your choice.
81+
That´s OpenUI5.</p>
82+
<p>Build enterprise-ready web applications, responsive to all devices and running on the browser of your choice.
83+
That´s OpenUI5.</p>
84+
<p>Build enterprise-ready web applications, responsive to all devices and running on the browser of your choice.
85+
That´s OpenUI5.</p>
86+
<p>Build enterprise-ready web applications, responsive to all devices and running on the browser of your choice.
87+
That´s OpenUI5.</p>
88+
<p>Build enterprise-ready web applications, responsive to all devices and running on the browser of your choice.
89+
That´s OpenUI5.</p>
90+
<p>Build enterprise-ready web applications, responsive to all devices and running on the browser of your choice.
91+
That´s OpenUI5.</p>
92+
<p>Build enterprise-ready web applications, responsive to all devices and running on the browser of your choice.
93+
That´s OpenUI5.</p>
4694

4795
<div slot="footer" style="display: flex; justify-content: flex-end; width: 100%; padding: .25rem 1rem;">
4896
<ui5-button design="Emphasized">OK</ui5-button>
@@ -107,7 +155,7 @@
107155

108156
<ui5-button id='popbtn'>Open Popover</ui5-button>
109157

110-
158+
111159

112160
<br>
113161
<br>

0 commit comments

Comments
 (0)