Skip to content

Commit a003189

Browse files
authoredNov 27, 2019
fix(ui5-tabcontainer): fix overflow item default semantic color (#989)
This is a follow up of Follow up of: #988 where overflow items appearance in negative, positive and critical states have been fixed. However, I missed the default semantic appearance. Now the default semantic appearance of the overflow item text and icon in active state also looks correct.
1 parent 9c43533 commit a003189

File tree

2 files changed

+8
-9
lines changed

2 files changed

+8
-9
lines changed
 

‎packages/main/src/themes/TabContainer.css

+1-6
Original file line numberDiff line numberDiff line change
@@ -233,15 +233,10 @@
233233
}
234234

235235
.ui5-tc__overflowItem ui5-icon {
236-
color: var(--sapUiNeutralText);
237-
}
238-
239-
.ui5-tc__overflowItem--positive ui5-icon,
240-
.ui5-tc__overflowItem--negative ui5-icon,
241-
.ui5-tc__overflowItem--critical ui5-icon {
242236
color: currentColor;
243237
}
244238

239+
245240
.ui5-tc__content {
246241
background-color: var(--sapUiGroupContentBackground);
247242
border-bottom: var(--_ui5_tc_content_border_bottom);

‎packages/main/test/pages/TabContainer.html

+7-3
Original file line numberDiff line numberDiff line change
@@ -83,9 +83,13 @@ <h4>Filter</h4>
8383
</ui5-tab>
8484
<ui5-tab icon="sap-icon://menu" text="Monitors" selected semantic-color="Critical" additional-text="45">
8585
</ui5-tab>
86-
<ui5-tab icon="sap-icon://menu2" text="Keyboards" semantic-color="Negative" additional-text="15">
87-
</ui5-tab>
88-
<ui5-tab icon="sap-icon://menu2" disabled="true" text="Disabled" semantic-color="Negative" additional-text="40">
86+
<ui5-tab icon="sap-icon://menu2" text="Keyboards" semantic-color="Negative" additional-text="15">
87+
</ui5-tab>
88+
<ui5-tab icon="sap-icon://menu2" disabled="true" text="Disabled" semantic-color="Negative" additional-text="40">
89+
</ui5-tab>
90+
<ui5-tab icon="sap-icon://menu2" text="Neutral" semantic-color="Neutral" additional-text="40">
91+
</ui5-tab>
92+
<ui5-tab icon="sap-icon://menu2" text="Default" additional-text="40">
8993
</ui5-tab>
9094
</ui5-tabcontainer>
9195
</div>

0 commit comments

Comments
 (0)
Please sign in to comment.