Skip to content

Commit a5aafde

Browse files
authored
fix(ui5-button): use base CSS param for border-radius (#2840)
There is a standard CSS variable --sapButton_BorderCornerRadius meant to be used for the Button's border-radius. It is 0.25rem in Fiori3 and 0.375rem in HCB and HCW themes. In terms of metrics nothing changes, we use the same values, but now we allow customization via the ThemeDesigner as we apply standard CSS variable. FIXES: #2830
1 parent 91d370a commit a5aafde

File tree

7 files changed

+1
-7
lines changed

7 files changed

+1
-7
lines changed

packages/main/src/themes/base/Button-parameters.css

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
--_ui5_button_base_min_compact_width: 2rem;
44
--_ui5_button_base_height: 2.5rem;
55
--_ui5_button_compact_height: 1.625rem;
6-
--_ui5_button_border_radius: 0.2rem;
6+
--_ui5_button_border_radius: var(--sapButton_BorderCornerRadius);
77
--_ui5_button_base_padding: 0.6875rem;
88
--_ui5_button_compact_padding: 0.4375rem;
99
--_ui5_button_base_icon_only_padding: 0.5625rem;

packages/main/src/themes/sap_belize_hcb/Button-parameters.css

-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
@import "../base/Button-parameters.css";
22

33
:root {
4-
--_ui5_button_border_radius: 0.375rem;
54
--_ui5_button_outline_offset: -0.125rem;
65
--_ui5_button_outline: 0.125rem dotted var(--sapContent_FocusColor);
76
--_ui5_button_positive_border_active_color: transparent;

packages/main/src/themes/sap_belize_hcw/Button-parameters.css

-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
@import "../base/Button-parameters.css";
22

33
:root {
4-
--_ui5_button_border_radius: 0.375rem;
54
--_ui5_button_outline_offset: -0.125rem;
65
--_ui5_button_outline: 0.125rem dotted var(--sapContent_FocusColor);
76
--_ui5_button_positive_border_active_color: transparent;

packages/main/src/themes/sap_fiori_3/Button-parameters.css

-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
:root {
44
--_ui5_button_base_min_width: 2.25rem;
55
--_ui5_button_base_height: 2.25rem;
6-
--_ui5_button_border_radius: 0.25rem;
76
--_ui5_button_base_padding: 0.5625rem;
87
--_ui5_button_base_icon_only_padding: 0.5625rem;
98
--_ui5_button_base_icon_margin: 0.375rem;

packages/main/src/themes/sap_fiori_3_dark/Button-parameters.css

-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
:root {
44
--_ui5_button_base_min_width: 2.25rem;
55
--_ui5_button_base_height: 2.25rem;
6-
--_ui5_button_border_radius: 0.25rem;
76
--_ui5_button_base_padding: 0.5625rem;
87
--_ui5_button_base_icon_only_padding: 0.5625rem;
98
--_ui5_button_base_icon_margin: 0.375rem;

packages/main/src/themes/sap_fiori_3_hcb/Button-parameters.css

-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
@import "../base/Button-parameters.css";
22

33
:root {
4-
--_ui5_button_border_radius: 0.375rem;
54
--_ui5_button_outline_offset: -0.25rem;
65
--_ui5_button_outline: 0.125rem dotted var(--sapContent_FocusColor);
76
--_ui5_button_positive_border_active_color: var(--sapButton_Emphasized_Active_Background);

packages/main/src/themes/sap_fiori_3_hcw/Button-parameters.css

-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
@import "../base/Button-parameters.css";
22

33
:root {
4-
--_ui5_button_border_radius: 0.375rem;
54
--_ui5_button_outline_offset: -0.25rem;
65
--_ui5_button_outline: 0.125rem dotted var(--sapContent_FocusColor);
76
--_ui5_button_positive_border_active_color: var(--sapButton_Emphasized_Active_Background);

0 commit comments

Comments
 (0)