Skip to content

Commit a5ccb80

Browse files
authored
fix: hide week number in Islamic, Buddhist Japanese calendars (#806)
1 parent 71c9caa commit a5ccb80

File tree

3 files changed

+14
-8
lines changed

3 files changed

+14
-8
lines changed

packages/main/src/DayPicker.hbs

+9-7
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,14 @@
11
<div class="ui5-dp-root" style="{{styles.wrapper}}">
22

3-
<div class="ui5-dp-weeknumber-container">
4-
{{#each _weekNumbers}}
5-
<div class="ui5-dp-weekname-container">
6-
<span class="ui5-dp-weekname">{{this}}</span>
7-
</div>
8-
{{/each}}
9-
</div>
3+
{{#if showWeekNumbers}}
4+
<div class="ui5-dp-weeknumber-container">
5+
{{#each _weekNumbers}}
6+
<div class="ui5-dp-weekname-container">
7+
<span class="ui5-dp-weekname">{{this}}</span>
8+
</div>
9+
{{/each}}
10+
</div>
11+
{{/if}}
1012

1113
<div id="{{_id}}-content" class="ui5-dp-content">
1214
<div role="row" class="ui5-dp-days-names-container">

packages/main/src/DayPicker.js

+4
Original file line numberDiff line numberDiff line change
@@ -300,6 +300,10 @@ class DayPicker extends UI5Element {
300300
}
301301
}
302302

303+
get showWeekNumbers() {
304+
return this.primaryCalendarType === CalendarType.Gregorian;
305+
}
306+
303307
get _timestamp() {
304308
return this.timestamp !== undefined ? this.timestamp : Math.floor(new Date().getTime() / 1000);
305309
}

packages/main/test/sap/ui/webcomponents/main/samples/Input.sample.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,7 @@ <h3>Input with Label</h3>
214214

215215
<script>
216216
var searchCriteria = "PASTA";
217-
searchIcon.addEventListener("press", function(){
217+
searchIcon.addEventListener("click", function(){
218218
alert("Look for: " + searchCriteria);
219219
});
220220
searchInput.addEventListener("input", function(e){

0 commit comments

Comments
 (0)