Skip to content

Commit a6f5c2b

Browse files
authored
fix(ui5-tabcontainer): import popover dependency (#46)
As the ui5-tabcontainer uses the ui5-popover, ui5-button, ui5-icon, ui5-list and ui5-li-custom internally for its overflow menu, the ui5-popover should be imported.
1 parent ca97de6 commit a6f5c2b

File tree

1 file changed

+18
-1
lines changed

1 file changed

+18
-1
lines changed

packages/main/src/TabContainer.js

+18-1
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,14 @@ import TabContainerTemplateContext from "./TabContainerTemplateContext";
88
import TabBase from "./TabBase";
99
import Tab from "./Tab";
1010
import TabSeparator from "./TabSeparator";
11+
import Popover from "./Popover";
12+
import List from "./List";
13+
import CustomListItem from "./CustomListItem";
14+
import Icon from "./Icon";
15+
import Button from "./Button";
16+
1117
import TabDesignMode from "./types/TabDesignMode";
1218
import IconColor from "./types/IconColor";
13-
1419
import BackgroundDesign from "./types/BackgroundDesign";
1520
import TabContainerHeaderMode from "./types/TabContainerHeaderMode";
1621
import ListItemType from "./types/ListItemType";
@@ -746,6 +751,18 @@ class TabContainer extends WebComponent {
746751
static get calculateTemplateContext() {
747752
return TabContainerTemplateContext.calculate;
748753
}
754+
755+
static async define(...params) {
756+
await Promise.all([
757+
Icon.define(),
758+
Button.define(),
759+
CustomListItem.define(),
760+
List.define(),
761+
Popover.define(),
762+
]);
763+
764+
super.define(...params);
765+
}
749766
}
750767

751768
Core.boot().then(_ => {

0 commit comments

Comments
 (0)