Skip to content

Commit a90c5f5

Browse files
authored
refactor(ui5-messagestrip): rename hideCloseButton property to noCloseButton (#508)
1 parent 11dc3b1 commit a90c5f5

File tree

4 files changed

+18
-18
lines changed

4 files changed

+18
-18
lines changed

packages/main/src/MessageStrip.hbs

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
<span class="ui5-messagestrip-hidden-text">{{hiddenText}}</span>
1111
<span class="{{classes.label}}"><slot></slot></span>
1212

13-
{{#unless hideCloseButton}}
13+
{{#unless noCloseButton}}
1414
<ui5-icon
1515
class="{{classes.closeIcon}}"
1616
src="sap-icon://decline"

packages/main/src/MessageStrip.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ const metadata = {
7474
* @defaultvalue false
7575
* @public
7676
*/
77-
hideCloseButton: {
77+
noCloseButton: {
7878
type: Boolean,
7979
},
8080

@@ -208,15 +208,15 @@ class MessageStrip extends UI5Element {
208208
return {
209209
label: {
210210
"ui5-messagestrip-text": true,
211-
"ui5-messagestripNoCloseButton": this.hideCloseButton,
211+
"ui5-messagestripNoCloseButton": this.noCloseButton,
212212
},
213213
closeIcon: {
214214
"ui5-messagestrip-close-icon": true,
215215
},
216216
main: {
217217
"ui5-messagestrip-root": true,
218218
"ui5-messagestrip-icon--hidden": this.hideIcon,
219-
"ui5-messagestrip-close-icon--hidden": this.hideCloseButton,
219+
"ui5-messagestrip-close-icon--hidden": this.noCloseButton,
220220
[this.typeClasses]: true,
221221
},
222222
};

packages/main/test/sap/ui/webcomponents/main/pages/MessageStrip.html

+2-2
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,8 @@
4242
<ui5-messagestrip class="top" type="Information">Ea mollit nulla laborum et fugiat nulla excepteur ea. Duis et dolor enim Lorem laboris adipisicing cillum quis proident dolor veniam voluptate. Nostrud dolore ipsum anim voluptate enim dolore eiusmod aliqua et. Est eu ex dolor ea ipsum. Adipisicing duis aliquip ullamco culpa dolore exercitation ullamco cillum irure.</ui5-messagestrip>
4343

4444
<ui5-messagestrip hide-icon class="top" type="Information">Ea mollit nulla laborum et fugiat nulla excepteur ea. Duis et dolor enim Lorem laboris adipisicing cillum quis proident dolor veniam voluptate. Nostrud dolore ipsum anim voluptate enim dolore eiusmod aliqua et. Est eu ex dolor ea ipsum. Adipisicing duis aliquip ullamco culpa dolore exercitation ullamco cillum irure.</ui5-messagestrip>
45-
<ui5-messagestrip hide-icon hide-close-button class="top" type="Information">Ea mollit nulla laborum et fugiat nulla excepteur ea. Duis et dolor enim Lorem laboris adipisicing cillum quis proident dolor veniam voluptate. Nostrud dolore ipsum anim voluptate enim dolore eiusmod aliqua et. Est eu ex dolor ea ipsum. Adipisicing duis aliquip ullamco culpa dolore exercitation ullamco cillum irure.</ui5-messagestrip>
46-
<ui5-messagestrip hide-close-button class="top" type="Information">Ea mollit nulla laborum et fugiat nulla excepteur ea. Duis et dolor enim Lorem laboris adipisicing cillum quis proident dolor veniam voluptate. Nostrud dolore ipsum anim voluptate enim dolore eiusmod aliqua et. Est eu ex dolor ea ipsum. Adipisicing duis aliquip ullamco culpa dolore exercitation ullamco cillum irure.</ui5-messagestrip>
45+
<ui5-messagestrip hide-icon no-close-button class="top" type="Information">Ea mollit nulla laborum et fugiat nulla excepteur ea. Duis et dolor enim Lorem laboris adipisicing cillum quis proident dolor veniam voluptate. Nostrud dolore ipsum anim voluptate enim dolore eiusmod aliqua et. Est eu ex dolor ea ipsum. Adipisicing duis aliquip ullamco culpa dolore exercitation ullamco cillum irure.</ui5-messagestrip>
46+
<ui5-messagestrip no-close-button class="top" type="Information">Ea mollit nulla laborum et fugiat nulla excepteur ea. Duis et dolor enim Lorem laboris adipisicing cillum quis proident dolor veniam voluptate. Nostrud dolore ipsum anim voluptate enim dolore eiusmod aliqua et. Est eu ex dolor ea ipsum. Adipisicing duis aliquip ullamco culpa dolore exercitation ullamco cillum irure.</ui5-messagestrip>
4747

4848

4949
<script>

packages/main/test/sap/ui/webcomponents/main/samples/MessageStrip.sample.html

+12-12
Original file line numberDiff line numberDiff line change
@@ -68,16 +68,16 @@ <h3>MessageStrip</h3>
6868
<section>
6969
<h3>MessageStrip With No Close Button</h3>
7070
<div class="snippet">
71-
<ui5-messagestrip class="samples-margin-bottom" type="Information" hide-close-button>Information MessageStrip With No Close Button</ui5-messagestrip>
72-
<ui5-messagestrip class="samples-margin-bottom" type="Positive" hide-close-button>Positive MessageStrip With No Close Button</ui5-messagestrip>
73-
<ui5-messagestrip class="samples-margin-bottom" type="Negative" hide-close-button>Negative MessageStrip With No Close Button</ui5-messagestrip>
74-
<ui5-messagestrip class="samples-margin-bottom" type="Warning" hide-close-button>Warning MessageStrip With No Close Button</ui5-messagestrip>
71+
<ui5-messagestrip class="samples-margin-bottom" type="Information" no-close-button>Information MessageStrip With No Close Button</ui5-messagestrip>
72+
<ui5-messagestrip class="samples-margin-bottom" type="Positive" no-close-button>Positive MessageStrip With No Close Button</ui5-messagestrip>
73+
<ui5-messagestrip class="samples-margin-bottom" type="Negative" no-close-button>Negative MessageStrip With No Close Button</ui5-messagestrip>
74+
<ui5-messagestrip class="samples-margin-bottom" type="Warning" no-close-button>Warning MessageStrip With No Close Button</ui5-messagestrip>
7575
</div>
7676
<pre class="prettyprint lang-html"><xmp>
77-
<ui5-messagestrip type="Information" hide-close-button>Information MessageStrip With No Close Button</ui5-messagestrip>
78-
<ui5-messagestrip type="Positive" hide-close-button>Positive MessageStrip With No Close Button</ui5-messagestrip>
79-
<ui5-messagestrip type="Negative" hide-close-button>Negative MessageStrip With No Close Button</ui5-messagestrip>
80-
<ui5-messagestrip type="Warning" hide-close-button>Warning MessageStrip With No Close Button</ui5-messagestrip>
77+
<ui5-messagestrip type="Information" no-close-button>Information MessageStrip With No Close Button</ui5-messagestrip>
78+
<ui5-messagestrip type="Positive" no-close-button>Positive MessageStrip With No Close Button</ui5-messagestrip>
79+
<ui5-messagestrip type="Negative" no-close-button>Negative MessageStrip With No Close Button</ui5-messagestrip>
80+
<ui5-messagestrip type="Warning" no-close-button>Warning MessageStrip With No Close Button</ui5-messagestrip>
8181
</xmp></pre>
8282
</section>
8383

@@ -107,14 +107,14 @@ <h3>MessageStrip With No Icon</h3>
107107
<section>
108108
<h3>Custom MessageStrip</h3>
109109
<div class="snippet">
110-
<ui5-messagestrip class="samples-margin-bottom samples-vertical-align" style="width: 200px;" type="Information" hide-icon hide-close-button>You have new message.</ui5-messagestrip>
111-
<ui5-messagestrip class="samples-margin-bottom samples-vertical-align" style="width: 200px;" type="Positive" hide-close-button>Successfull login!</ui5-messagestrip>
110+
<ui5-messagestrip class="samples-margin-bottom samples-vertical-align" style="width: 200px;" type="Information" hide-icon no-close-button>You have new message.</ui5-messagestrip>
111+
<ui5-messagestrip class="samples-margin-bottom samples-vertical-align" style="width: 200px;" type="Positive" no-close-button>Successfull login!</ui5-messagestrip>
112112
<ui5-messagestrip class="samples-margin-bottom samples-vertical-align" style="width: 200px;" type="Negative" hide-icon>Access denied!</ui5-messagestrip>
113113
<ui5-messagestrip class="samples-margin-bottom samples-vertical-align" style="width: 200px;" type="Warning">Update is required.</ui5-messagestrip>
114114
</div>
115115
<pre class="prettyprint lang-html"><xmp>
116-
<ui5-messagestrip type="Information" style="width: 200px;" hide-icon hide-close-button>You have new message.</ui5-messagestrip>
117-
<ui5-messagestrip type="Positive" style="width: 200px;" hide-close-button>Successfull login!</ui5-messagestrip>
116+
<ui5-messagestrip type="Information" style="width: 200px;" hide-icon no-close-button>You have new message.</ui5-messagestrip>
117+
<ui5-messagestrip type="Positive" style="width: 200px;" no-close-button>Successfull login!</ui5-messagestrip>
118118
<ui5-messagestrip type="Negative" style="width: 200px;" hide-icon>Access denied!</ui5-messagestrip>
119119
<ui5-messagestrip type="Warning" style="width: 200px;">Update is required.</ui5-messagestrip>
120120
<script>

0 commit comments

Comments
 (0)