Skip to content

Commit b1e2eaf

Browse files
authored
fix(ui5-color-palette): rename change event (#3429)
Part of #3107 BREAKING_CHANGE: change event of ui5-color-palette is renamed to item-click
1 parent cf1b64d commit b1e2eaf

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

packages/main/src/ColorPalette.js

+3-2
Original file line numberDiff line numberDiff line change
@@ -79,9 +79,10 @@ const metadata = {
7979
*
8080
* @event
8181
* @public
82+
* @since 1.0.0-rc.15
8283
* @param {String} color the selected color
8384
*/
84-
change: {
85+
"item-click": {
8586
details: {
8687
color: {
8788
type: String,
@@ -196,7 +197,7 @@ class ColorPalette extends UI5Element {
196197
}
197198
}
198199

199-
this.fireEvent("change", {
200+
this.fireEvent("item-click", {
200201
color: this._selectedColor,
201202
});
202203
}

packages/main/test/pages/ColorPalette.html

+5-3
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@
5858
<br/>
5959
<br/>
6060
<br/>
61-
<ui5-input id="changeResult" value="Nothing selected"></ui5-input>
61+
<ui5-input id="itemClickResult" value="Nothing selected"></ui5-input>
6262
<br>
6363
<ui5-button id="colorPaletteBtn" >Open ColorPalette</ui5-button>
6464
<ui5-responsive-popover id="respPopover" with-padding>
@@ -125,12 +125,14 @@
125125
</ui5-color-palette>
126126

127127
<script>
128-
cp1.addEventListener("change", function(event) {
129-
changeResult.value = event.detail.color;
128+
cp1.addEventListener("item-click", function(event) {
129+
itemClickResult.value = event.detail.color;
130130
});
131+
131132
colorPaletteBtn.addEventListener("click", function(event) {
132133
respPopover.open(colorPaletteBtn);
133134
});
135+
134136
btnClose.addEventListener("click", function(event) {
135137
respPopover.close();
136138
});

0 commit comments

Comments
 (0)