Skip to content

Commit b2c770a

Browse files
authored
fix(ui5-combobox, ui5-multicombobox): center ValueState text (#2733)
ValueState text is now vertically centered in the Popover's header. Fixes: #2274
1 parent 418034e commit b2c770a

File tree

4 files changed

+5
-6
lines changed

4 files changed

+5
-6
lines changed

packages/main/src/ComboBox.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -814,7 +814,7 @@ class ComboBox extends UI5Element {
814814
suggestionPopoverHeader: {
815815
"display": this._listWidth === 0 ? "none" : "inline-block",
816816
"width": `${this._listWidth}px`,
817-
"padding": "0.5625rem 1rem",
817+
"padding": "0.9125rem 1rem",
818818
},
819819
};
820820
}

packages/main/src/MultiComboBox.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -872,9 +872,8 @@ class MultiComboBox extends UI5Element {
872872
return {
873873
popoverValueStateMessage: {
874874
"width": `${this._listWidth}px`,
875-
"min-height": "2.5rem",
876-
"padding": "0.5625rem 1rem",
877875
"display": this._listWidth === 0 ? "none" : "inline-block",
876+
"padding": "0.9125rem 1rem",
878877
},
879878
popoverHeader: {
880879
"width": `${this._inputWidth}px`,

packages/main/src/themes/ResponsivePopover.css

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
}
1414

1515
.ui5-responsive-popover-header {
16-
height: var(--_ui5-responnsive_popover_header_height);
16+
height: var(--_ui5-responsive_popover_header_height);
1717
display: flex;
1818
justify-content: space-between;
1919
align-items: center;

packages/main/src/themes/base/sizes-parameters.css

+2-2
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@
7070
--_ui5_textarea_padding: 0.5625rem 0.6875rem;
7171

7272
/* Responsive Popover */
73-
--_ui5-responnsive_popover_header_height: 2.75rem;
73+
--_ui5-responsive_popover_header_height: 2.75rem;
7474

7575
/* Side Navigation */
7676
--ui5_side_navigation_item_height: 2.75rem;
@@ -210,7 +210,7 @@
210210
--_ui5_radiobutton_min_width: var(--_ui5_radiobutton_min_width_compact);
211211

212212
/* Responsive Popover */
213-
--_ui5-responnsive_popover_header_height: 2.5rem;
213+
--_ui5-responsive_popover_header_height: 2.5rem;
214214

215215
/* Side Navigation */
216216
--ui5_side_navigation_item_height: 2rem;

0 commit comments

Comments
 (0)