Skip to content

Commit bc00f1f

Browse files
authored
fix(ui5-button): fix Transparent button border in Fiori 3 & HCB (#789)
1 parent 3af76de commit bc00f1f

File tree

4 files changed

+9
-4
lines changed

4 files changed

+9
-4
lines changed

packages/main/src/themes/Button.css

+2-3
Original file line numberDiff line numberDiff line change
@@ -217,10 +217,9 @@ bdi {
217217

218218
:host([design="Transparent"]) {
219219
background-color: var(--sapUiButtonLiteBackground);
220-
border-color: var(--sapUiButtonLiteBorderColor);
221220
color: var(--sapUiButtonLiteTextColor);
222221
text-shadow: var(--_ui5_button_text_shadow);
223-
border-color: transparent;
222+
border-color: var(--_ui5_button_transparent_border_color);
224223
}
225224

226225
:host([design="Transparent"]):hover {
@@ -234,7 +233,7 @@ bdi {
234233
}
235234

236235
:host([design="Transparent"]:not([active]):hover) {
237-
border-color: transparent;
236+
border-color: var(--_ui5_button_transparent_hover_border_color);
238237
}
239238

240239
/* IE Specific CSS */

packages/main/src/themes/base/Button-parameters.css

+2-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,8 @@
1717
--_ui5_button_focus_width: 1px;
1818
--_ui5_button_focus_color: var(--sapUiContentFocusColor);
1919

20-
20+
--_ui5_button_transparent_border_color: transparent;
21+
--_ui5_button_transparent_hover_border_color: var(--sapUiButtonBorderColor);
2122
--_ui5_button_active_border_color: var(--sapUiButtonActiveBorderColor);
2223
--_ui5_button_positive_border_color: var(--sapUiButtonAcceptBorderColor);
2324
--_ui5_button_positive_border_hover_color: var(--sapUiButtonAcceptHoverBorderColor);
Original file line numberDiff line numberDiff line change
@@ -1 +1,5 @@
11
@import "../base/Button-parameters.css";
2+
3+
:root {
4+
--_ui5_button_transparent_hover_border_color: transparent;
5+
}

packages/main/src/themes/sap_belize_hcb/Button-parameters.css

+1
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
--_ui5_button_positive_focus_border_color: transparent;
1010
--_ui5_button_negative_focus_border_color: transparent;
1111
--_ui5_button_negative_active_border_color: transparent;
12+
--_ui5_button_transparent_border_color: var(--sapUiButtonBorderColor);
1213
--_ui5_button_focus_width: 1px;
1314
--_ui5_button_focus_color: var(--sapUiContentFocusColor);
1415
--_ui5_button_focussed_border_color: transparent;

0 commit comments

Comments
 (0)