Skip to content

Commit c5e00c4

Browse files
authored
fix(ui5-popup): scroll handle is now working for input controls (#3414)
1 parent 8aaf99b commit c5e00c4

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

packages/main/src/Popup.hbs

-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
aria-label="{{_ariaLabel}}"
77
aria-labelledby="{{_ariaLabelledBy}}"
88
dir="{{effectiveDir}}"
9-
tabindex="-1"
109
@keydown={{_onkeydown}}
1110
@focusout={{_onfocusout}}
1211
>

packages/main/src/Popup.js

+4
Original file line numberDiff line numberDiff line change
@@ -278,6 +278,7 @@ class Popup extends UI5Element {
278278
_onfocusout(e) {
279279
// relatedTarget is the element, which will get focus. If no such element exists, focus the root
280280
if (!e.relatedTarget) {
281+
this._root.tabIndex = -1;
281282
this._root.focus();
282283
}
283284
}
@@ -334,6 +335,9 @@ class Popup extends UI5Element {
334335
|| this._root; // in case of no focusable content focus the root
335336

336337
if (element) {
338+
if (element === this._root) {
339+
element.tabIndex = -1;
340+
}
337341
element.focus();
338342
}
339343
}

0 commit comments

Comments
 (0)