Skip to content

Commit c9c0e0b

Browse files
committed
Add appenddocs and since tags, sample docs fix
1 parent cb80ab4 commit c9c0e0b

File tree

3 files changed

+44
-5
lines changed

3 files changed

+44
-5
lines changed

packages/main/debug.log

+36
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
[1115/190746.143:ERROR:process_reader_win.cc(123)] NtOpenThread: {Access Denied} A process has requested access to an object, but has not been granted those access rights. (0xc0000022)
2+
[1115/190746.146:ERROR:exception_snapshot_win.cc(99)] thread ID 24416 not found in process
3+
[1115/200309.808:ERROR:process_reader_win.cc(123)] NtOpenThread: {Access Denied} A process has requested access to an object, but has not been granted those access rights. (0xc0000022)
4+
[1115/200309.809:ERROR:exception_snapshot_win.cc(99)] thread ID 37412 not found in process
5+
[1115/200309.831:ERROR:process_reader_win.cc(123)] NtOpenThread: {Access Denied} A process has requested access to an object, but has not been granted those access rights. (0xc0000022)
6+
[1115/200309.832:ERROR:exception_snapshot_win.cc(99)] thread ID 32636 not found in process
7+
[1115/200417.889:ERROR:process_reader_win.cc(123)] NtOpenThread: {Access Denied} A process has requested access to an object, but has not been granted those access rights. (0xc0000022)
8+
[1115/200417.891:ERROR:exception_snapshot_win.cc(99)] thread ID 49336 not found in process
9+
[1115/200417.910:ERROR:process_reader_win.cc(123)] NtOpenThread: {Access Denied} A process has requested access to an object, but has not been granted those access rights. (0xc0000022)
10+
[1115/200417.910:ERROR:exception_snapshot_win.cc(99)] thread ID 25108 not found in process
11+
[1115/200518.134:ERROR:process_reader_win.cc(123)] NtOpenThread: {Access Denied} A process has requested access to an object, but has not been granted those access rights. (0xc0000022)
12+
[1115/200518.136:ERROR:exception_snapshot_win.cc(99)] thread ID 39420 not found in process
13+
[1115/200518.155:ERROR:process_reader_win.cc(123)] NtOpenThread: {Access Denied} A process has requested access to an object, but has not been granted those access rights. (0xc0000022)
14+
[1115/200518.156:ERROR:exception_snapshot_win.cc(99)] thread ID 32120 not found in process
15+
[1115/222805.032:ERROR:process_reader_win.cc(123)] NtOpenThread: {Access Denied} A process has requested access to an object, but has not been granted those access rights. (0xc0000022)
16+
[1115/222805.034:ERROR:exception_snapshot_win.cc(99)] thread ID 26132 not found in process
17+
[1115/222805.054:ERROR:process_reader_win.cc(123)] NtOpenThread: {Access Denied} A process has requested access to an object, but has not been granted those access rights. (0xc0000022)
18+
[1115/222805.054:ERROR:exception_snapshot_win.cc(99)] thread ID 52764 not found in process
19+
[1115/222843.639:ERROR:process_reader_win.cc(123)] NtOpenThread: {Access Denied} A process has requested access to an object, but has not been granted those access rights. (0xc0000022)
20+
[1115/222843.641:ERROR:exception_snapshot_win.cc(99)] thread ID 55836 not found in process
21+
[1115/222843.663:ERROR:process_reader_win.cc(123)] NtOpenThread: {Access Denied} A process has requested access to an object, but has not been granted those access rights. (0xc0000022)
22+
[1115/222843.663:ERROR:exception_snapshot_win.cc(99)] thread ID 10768 not found in process
23+
[1115/235527.379:ERROR:process_reader_win.cc(123)] NtOpenThread: {Access Denied} A process has requested access to an object, but has not been granted those access rights. (0xc0000022)
24+
[1115/235527.381:ERROR:exception_snapshot_win.cc(99)] thread ID 15440 not found in process
25+
[1115/235637.656:ERROR:process_reader_win.cc(123)] NtOpenThread: {Access Denied} A process has requested access to an object, but has not been granted those access rights. (0xc0000022)
26+
[1115/235637.659:ERROR:exception_snapshot_win.cc(99)] thread ID 37192 not found in process
27+
[1115/235637.686:ERROR:process_reader_win.cc(123)] NtOpenThread: {Access Denied} A process has requested access to an object, but has not been granted those access rights. (0xc0000022)
28+
[1115/235637.686:ERROR:exception_snapshot_win.cc(99)] thread ID 16908 not found in process
29+
[1116/000415.338:ERROR:process_reader_win.cc(123)] NtOpenThread: {Access Denied} A process has requested access to an object, but has not been granted those access rights. (0xc0000022)
30+
[1116/000415.341:ERROR:exception_snapshot_win.cc(99)] thread ID 35368 not found in process
31+
[1116/000437.669:ERROR:process_reader_win.cc(123)] NtOpenThread: {Access Denied} A process has requested access to an object, but has not been granted those access rights. (0xc0000022)
32+
[1116/000437.671:ERROR:exception_snapshot_win.cc(99)] thread ID 34420 not found in process
33+
[1116/073652.537:ERROR:process_reader_win.cc(123)] NtOpenThread: {Access Denied} A process has requested access to an object, but has not been granted those access rights. (0xc0000022)
34+
[1116/073652.538:ERROR:exception_snapshot_win.cc(99)] thread ID 50460 not found in process
35+
[1116/073652.554:ERROR:process_reader_win.cc(123)] NtOpenThread: {Access Denied} A process has requested access to an object, but has not been granted those access rights. (0xc0000022)
36+
[1116/073652.554:ERROR:exception_snapshot_win.cc(99)] thread ID 43292 not found in process

packages/main/src/Slider.js

+3-2
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ const metadata = {
4343
* <li>value - The current value of the slider</li>
4444
* <li>step - Determines the increments in which the slider will move</li>
4545
* <li>showTooltip - Determines if a tooltip should be displayed above the handle</li>
46-
* <li>tickmarks - Displays a visual divider between the step values</li>
46+
* <li>showTickmarks - Displays a visual divider between the step values</li>
4747
* <li>labelInterval - Labels some or all of the tickmarks with their values.</li>
4848
* </ul>
4949
*
@@ -67,6 +67,8 @@ const metadata = {
6767
* @alias sap.ui.webcomponents.main.Slider
6868
* @extends sap.ui.webcomponents.base.UI5Element
6969
* @tagname ui5-slider
70+
* @since 1.0.0-rc.11
71+
* @appenddocs SliderBase
7072
* @public
7173
*/
7274
class Slider extends SliderBase {
@@ -125,7 +127,6 @@ class Slider extends SliderBase {
125127

126128
// Do not yet update the Slider if press is over a handle. It will be updated if the user drags the mouse.
127129
if (!this._isHandlePressed(SliderBase.getPageXValueFromEvent(event))) {
128-
// Update Slider UI and internal state
129130
this._updateUI(newValue);
130131
this.updateValue("value", newValue);
131132
}

packages/main/test/samples/Slider.sample.html

+5-3
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ <h3>Slider with Tooltip</h3>
3333
<section>
3434
<h3>Disabled Slider with Tickmarks and Labels</h3>
3535
<div class="snippet">
36-
<ui5-slider class="samples-margin" min="20" max="100" label-interval="5" disabled show-tickmarks></ui5-slider>
36+
<ui5-slider class="samples-margin" min="20" max="100" label-interval="5" disabled show-tickmarks></ui5-slider>
3737
</div>
3838
<pre class="prettyprint lang-html"><xmp>
3939
<ui5-slider min="20" max="100" label-interval="5" disabled show-tickmarks></ui5-slider>
@@ -46,6 +46,8 @@ <h3>Slider tooltip, tickmarks and labels</h3>
4646
<ui5-slider class="samples-margin" min="-20" max="20" step="2" value="12" show-tooltip label-interval="2" show-tickmarks></ui5-slider>
4747
</div>
4848
<pre class="prettyprint lang-html"><xmp>
49-
<ui5-slider min="-20" max="20" step="2" value="12" show-tooltip label-interval="2" show-tickmarks></ui5-slider>
49+
<ui5-slider min="-20" max="20" step="2" value="12" show-tooltip label-interval="2" show-tickmarks></ui5-slider>
5050
</xmp></pre>
51-
</section>
51+
</section>
52+
53+
<!-- JSDoc marker -->

0 commit comments

Comments
 (0)